* [Qemu-devel] [PATCH] hw/usb-musb.c: Don't misuse usb_packet_complete()
@ 2011-06-14 11:24 Peter Maydell
2011-06-29 9:43 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Peter Maydell @ 2011-06-14 11:24 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann, patches
In musb_packet() handle final processing of non-asynchronous
USB packets by directly calling musb_schedule_cb() rather than
going through usb_packet_complete(). The latter will trigger
an assertion because the packet doesn't belong to a device.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
The fix here is as suggested by Gerd.
hw/usb-musb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/usb-musb.c b/hw/usb-musb.c
index 6037193..3eed855 100644
--- a/hw/usb-musb.c
+++ b/hw/usb-musb.c
@@ -611,7 +611,7 @@ static void musb_packet(MUSBState *s, MUSBEndPoint *ep,
}
ep->status[dir] = ret;
- usb_packet_complete(s->port.dev, &ep->packey[dir].p);
+ musb_schedule_cb(s->port.dev, &ep->packey[dir].p);
}
static void musb_tx_packet_complete(USBPacket *packey, void *opaque)
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/usb-musb.c: Don't misuse usb_packet_complete()
2011-06-14 11:24 [Qemu-devel] [PATCH] hw/usb-musb.c: Don't misuse usb_packet_complete() Peter Maydell
@ 2011-06-29 9:43 ` Peter Maydell
2011-06-29 9:58 ` Gerd Hoffmann
0 siblings, 1 reply; 3+ messages in thread
From: Peter Maydell @ 2011-06-29 9:43 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann, patches
Gerd: ping?
thanks
-- PMM
On 14 June 2011 12:24, Peter Maydell <peter.maydell@linaro.org> wrote:
> In musb_packet() handle final processing of non-asynchronous
> USB packets by directly calling musb_schedule_cb() rather than
> going through usb_packet_complete(). The latter will trigger
> an assertion because the packet doesn't belong to a device.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> The fix here is as suggested by Gerd.
>
> hw/usb-musb.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/usb-musb.c b/hw/usb-musb.c
> index 6037193..3eed855 100644
> --- a/hw/usb-musb.c
> +++ b/hw/usb-musb.c
> @@ -611,7 +611,7 @@ static void musb_packet(MUSBState *s, MUSBEndPoint *ep,
> }
>
> ep->status[dir] = ret;
> - usb_packet_complete(s->port.dev, &ep->packey[dir].p);
> + musb_schedule_cb(s->port.dev, &ep->packey[dir].p);
> }
>
> static void musb_tx_packet_complete(USBPacket *packey, void *opaque)
> --
> 1.7.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/usb-musb.c: Don't misuse usb_packet_complete()
2011-06-29 9:43 ` Peter Maydell
@ 2011-06-29 9:58 ` Gerd Hoffmann
0 siblings, 0 replies; 3+ messages in thread
From: Gerd Hoffmann @ 2011-06-29 9:58 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-devel, patches
On 06/29/11 11:43, Peter Maydell wrote:
> Gerd: ping?
Oops, slipped through somehow. Picked into the usb queue now.
cheers,
Gerd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-06-29 9:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-14 11:24 [Qemu-devel] [PATCH] hw/usb-musb.c: Don't misuse usb_packet_complete() Peter Maydell
2011-06-29 9:43 ` Peter Maydell
2011-06-29 9:58 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).