From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:39665)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QbuTX-00068l-Mo
	for qemu-devel@nongnu.org; Wed, 29 Jun 2011 09:06:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QbuTW-0003UR-0j
	for qemu-devel@nongnu.org; Wed, 29 Jun 2011 09:06:39 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38853)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QbuTV-0003U0-AC
	for qemu-devel@nongnu.org; Wed, 29 Jun 2011 09:06:37 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5TD6a4R013317
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 29 Jun 2011 09:06:36 -0400
Message-ID: <4E0B2359.7000702@redhat.com>
Date: Wed, 29 Jun 2011 15:06:33 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1309348641-20061-1-git-send-email-alevy@redhat.com>
	<1309348641-20061-13-git-send-email-alevy@redhat.com>
In-Reply-To: <1309348641-20061-13-git-send-email-alevy@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv3] qxl: add QXL_IO_FLUSH_{SURFACES,
 RELEASE} for guest S3&S4 support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alon Levy <alevy@redhat.com>
Cc: yhalperi@redhat.com, qemu-devel@nongnu.org

   Hi,

> +    case QXL_IO_FLUSH_SURFACES:
> +        dprint(d, 1, "QXL_IO_FLUSH_SURFACES (%d) entry (%s, s#=%d, res#=%d)\n",
> +            val, qxl_mode_to_string(d->mode), d->guest_surfaces.count,
> +            d->num_free_res);
> +        qemu_spice_stop(&d->ssd);
> +        qemu_spice_start(&d->ssd);
> +        dprint(d, 1, "QXL_IO_FLUSH_SURFACES exit (%s, s#=%d, res#=%d,%p)\n",
> +            qxl_mode_to_string(d->mode), d->guest_surfaces.count,
> +            d->num_free_res, d->last_release);
> +        break;

This should be async as we'll go sleep and wait for the spice server 
thread finish in qemu_spice_stop().

> +    case QXL_IO_FLUSH_RELEASE: {
> +        QXLReleaseRing *ring =&d->ram->release_ring;
> +        if (ring->prod - ring->cons + 1 == ring->num_items) {
> +            // TODO - "return" a value to the guest and let it loop?
                   ^^^^
Hmm.

cheers,
   Gerd