From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41460) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qbvqg-0004gR-R5 for qemu-devel@nongnu.org; Wed, 29 Jun 2011 10:34:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qbvqf-0006bK-02 for qemu-devel@nongnu.org; Wed, 29 Jun 2011 10:34:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62641) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qbvqe-0006bG-IT for qemu-devel@nongnu.org; Wed, 29 Jun 2011 10:34:36 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5TEYZjW006907 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 29 Jun 2011 10:34:35 -0400 Message-ID: <4E0B37F8.80701@redhat.com> Date: Wed, 29 Jun 2011 16:34:32 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1309348641-20061-1-git-send-email-alevy@redhat.com> <1309348641-20061-7-git-send-email-alevy@redhat.com> <4E0B1E1B.4070803@redhat.com> <20110629142408.GW30873@bow.redhat.com> In-Reply-To: <20110629142408.GW30873@bow.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv3] qxl: abort on panic instead of exit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, yhalperi@redhat.com Hi, > Agreed. So keep PANIC_ON but remove a lot of it's users, or add some wrapper > that depends on a "guest_panic" parameter that defaults off. Maybe keep PANIC_ON in case there are any which can trigger on qemu bugs only. Add a new one where the name makes clear this triggers on case the guest driver does something wrong, maybe qxl_guest_bug() or so. Note this isn't a simple search/replace as qemu continues execution, but still has to ignore the invalid request from the guest (and maybe raise an error irq)? cheers, Gerd