* [Qemu-devel] [PATCH resend] vl.c: Don't limit node count by smp count
@ 2011-06-30 3:29 Sasha Levin
2011-06-30 9:14 ` Andre Przywara
2011-07-23 16:55 ` Anthony Liguori
0 siblings, 2 replies; 3+ messages in thread
From: Sasha Levin @ 2011-06-30 3:29 UTC (permalink / raw)
To: qemu-devel; +Cc: Sasha Levin
[I've sent this patch couple of months ago and noticed it
didn't make it's way in - so I'm sending it again]
It is possible to create CPU-less NUMA nodes, node amount shouldn't be
limited by amount of CPUs.
Tested-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
---
vl.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/vl.c b/vl.c
index e0191e1..b95ae8d 100644
--- a/vl.c
+++ b/vl.c
@@ -3147,8 +3147,8 @@ int main(int argc, char **argv, char **envp)
if (nb_numa_nodes > 0) {
int i;
- if (nb_numa_nodes > smp_cpus) {
- nb_numa_nodes = smp_cpus;
+ if (nb_numa_nodes > MAX_NODES) {
+ nb_numa_nodes = MAX_NODES;
}
/* If no memory size if given for any node, assume the default case
--
1.7.6
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH resend] vl.c: Don't limit node count by smp count
2011-06-30 3:29 [Qemu-devel] [PATCH resend] vl.c: Don't limit node count by smp count Sasha Levin
@ 2011-06-30 9:14 ` Andre Przywara
2011-07-23 16:55 ` Anthony Liguori
1 sibling, 0 replies; 3+ messages in thread
From: Andre Przywara @ 2011-06-30 9:14 UTC (permalink / raw)
To: qemu-devel@nongnu.org; +Cc: Sasha Levin
On 06/30/2011 05:29 AM, Sasha Levin wrote:
> [I've sent this patch couple of months ago and noticed it
> didn't make it's way in - so I'm sending it again]
>
> It is possible to create CPU-less NUMA nodes, node amount shouldn't be
> limited by amount of CPUs.
>
> Tested-by: Michael Roth<mdroth@linux.vnet.ibm.com>
> Signed-off-by: Sasha Levin<levinsasha928@gmail.com>
> ---
> vl.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index e0191e1..b95ae8d 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3147,8 +3147,8 @@ int main(int argc, char **argv, char **envp)
> if (nb_numa_nodes> 0) {
> int i;
>
> - if (nb_numa_nodes> smp_cpus) {
> - nb_numa_nodes = smp_cpus;
> + if (nb_numa_nodes> MAX_NODES) {
> + nb_numa_nodes = MAX_NODES;
> }
>
> /* If no memory size if given for any node, assume the default case
Acked-by: Andre Przywara <andre.przywara@amd.com>
Regards,
Andre.
--
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH resend] vl.c: Don't limit node count by smp count
2011-06-30 3:29 [Qemu-devel] [PATCH resend] vl.c: Don't limit node count by smp count Sasha Levin
2011-06-30 9:14 ` Andre Przywara
@ 2011-07-23 16:55 ` Anthony Liguori
1 sibling, 0 replies; 3+ messages in thread
From: Anthony Liguori @ 2011-07-23 16:55 UTC (permalink / raw)
To: Sasha Levin; +Cc: qemu-devel
On 06/29/2011 10:29 PM, Sasha Levin wrote:
> [I've sent this patch couple of months ago and noticed it
> didn't make it's way in - so I'm sending it again]
>
> It is possible to create CPU-less NUMA nodes, node amount shouldn't be
> limited by amount of CPUs.
>
> Tested-by: Michael Roth<mdroth@linux.vnet.ibm.com>
> Signed-off-by: Sasha Levin<levinsasha928@gmail.com>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> vl.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index e0191e1..b95ae8d 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3147,8 +3147,8 @@ int main(int argc, char **argv, char **envp)
> if (nb_numa_nodes> 0) {
> int i;
>
> - if (nb_numa_nodes> smp_cpus) {
> - nb_numa_nodes = smp_cpus;
> + if (nb_numa_nodes> MAX_NODES) {
> + nb_numa_nodes = MAX_NODES;
> }
>
> /* If no memory size if given for any node, assume the default case
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-07-23 16:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-30 3:29 [Qemu-devel] [PATCH resend] vl.c: Don't limit node count by smp count Sasha Levin
2011-06-30 9:14 ` Andre Przywara
2011-07-23 16:55 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).