From: Gerd Hoffmann <kraxel@redhat.com>
To: Yonit Halperin <yhalperi@redhat.com>
Cc: Alon Levy <alevy@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_UPDATE_MEM for guest S3&S4 support
Date: Thu, 30 Jun 2011 12:46:59 +0200 [thread overview]
Message-ID: <4E0C5423.2060208@redhat.com> (raw)
In-Reply-To: <4E0C4F52.90405@redhat.com>
Hi,
>> Right - the whole ring assumes that the same side removes. of course we
>> can add an IO for that (two - FREEZE and UNFREEZE). But I think this is
>> the wrong approach. Instead, rendering all the commands, and dropping the
>> wait for the client. Right now if we flush we do actually wait for the
>> client,
>> but I plan to remove this later. (we do this right now for update_area as
>> well and that's much higher frequency).
> To conclude, we still need to flush the command ring before stop. We
> don't want to change migration. So we still need to change spice server
> api. Gerd?
Yes, looks like there is no way around that to flush the command rings.
When we have to change the spice-server api anyway, then we should
support async I/O at libspice-server API level I think. Drop the qxl
async thread, have a way to submit async requests to the worker, let
libspice call us back on completion.
comments?
cheers,
Gerd
next prev parent reply other threads:[~2011-06-30 10:47 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 11:11 [Qemu-devel] [PATCH 0/2] Suspend (S3) support Alon Levy
2011-06-20 11:11 ` [Qemu-devel] [PATCH 1/2] qxl: interface_get_command: fix reported mode Alon Levy
2011-06-20 11:11 ` [Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_UPDATE_MEM for guest S3&S4 support Alon Levy
2011-06-20 12:13 ` Gerd Hoffmann
2011-06-20 12:57 ` Alon Levy
2011-06-20 12:58 ` Alon Levy
2011-06-20 14:07 ` Gerd Hoffmann
2011-06-20 15:11 ` Alon Levy
2011-06-20 15:48 ` Alon Levy
2011-06-20 15:50 ` Gerd Hoffmann
2011-06-20 16:32 ` Alon Levy
2011-06-20 20:53 ` Alon Levy
2011-06-21 6:29 ` Yonit Halperin
2011-06-22 9:13 ` Gerd Hoffmann
2011-06-22 9:57 ` Alon Levy
2011-06-26 16:59 ` Yonit Halperin
2011-06-26 17:47 ` Alon Levy
2011-06-27 6:28 ` yhalperi
2011-06-27 8:16 ` Alon Levy
2011-06-27 8:25 ` yhalperi
2011-06-27 9:20 ` Alon Levy
2011-06-29 9:01 ` Gerd Hoffmann
2011-06-29 9:21 ` Alon Levy
2011-06-29 10:25 ` Gerd Hoffmann
2011-06-29 11:38 ` Alon Levy
2011-06-30 10:26 ` Yonit Halperin
2011-06-30 10:46 ` Gerd Hoffmann [this message]
2011-06-30 11:41 ` Alon Levy
2011-06-30 12:12 ` Gerd Hoffmann
2011-06-30 12:50 ` Alon Levy
2011-06-30 13:17 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0C5423.2060208@redhat.com \
--to=kraxel@redhat.com \
--cc=alevy@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yhalperi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).