From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:57616)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1QcFio-00031R-Ii
	for qemu-devel@nongnu.org; Thu, 30 Jun 2011 07:47:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1QcFin-0003Pv-8D
	for qemu-devel@nongnu.org; Thu, 30 Jun 2011 07:47:50 -0400
Received: from cantor2.suse.de ([195.135.220.15]:39540 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1QcFim-0003Pn-PY
	for qemu-devel@nongnu.org; Thu, 30 Jun 2011 07:47:49 -0400
Message-ID: <4E0C6263.20908@suse.de>
Date: Thu, 30 Jun 2011 13:47:47 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1308927034-10209-1-git-send-email-stefano.stabellini@eu.citrix.com>
	<1308927034-10209-2-git-send-email-stefano.stabellini@eu.citrix.com>
In-Reply-To: <1308927034-10209-2-git-send-email-stefano.stabellini@eu.citrix.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] xen_disk: treat "aio" as "raw"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: stefano.stabellini@eu.citrix.com
Cc: Kevin Wolf <kwolf@redhat.com>, xen-devel@lists.xensource.com, qemu-devel@nongnu.org

On 06/24/2011 04:50 PM, stefano.stabellini@eu.citrix.com wrote:
> From: Stefano Stabellini<stefano.stabellini@eu.citrix.com>
>
> Sometimes the toolstack uses "aio" without an additional format
> identifier, in such cases use "raw".

Shouldn't this rather be a patch to the toolstack then? We do automatic 
file format recognition as default. I find magical "aio equals raw" 
subtleties rather unintuitive.


> Signed-off-by: Stefano Stabellini<stefano.stabellini@eu.citrix.com>
> ---
>   hw/xen_disk.c |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/hw/xen_disk.c b/hw/xen_disk.c
> index 801da58..745127d 100644
> --- a/hw/xen_disk.c
> +++ b/hw/xen_disk.c
> @@ -633,6 +633,8 @@ static int blk_init(struct XenDevice *xendev)
>               blkdev->filename  = blkdev->params;
>           }
>       }
> +    if (!strcmp("aio", blkdev->fileproto))
> +        blkdev->fileproto = "raw";

Braces

>       if (blkdev->mode == NULL) {
>           blkdev->mode = xenstore_read_be_str(&blkdev->xendev, "mode");
>       }


Alex