From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33117) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QcG7W-0000az-2p for qemu-devel@nongnu.org; Thu, 30 Jun 2011 08:13:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QcG7T-0001IY-Md for qemu-devel@nongnu.org; Thu, 30 Jun 2011 08:13:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19320) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QcG7T-0001IT-2o for qemu-devel@nongnu.org; Thu, 30 Jun 2011 08:13:19 -0400 Message-ID: <4E0C6905.2040604@redhat.com> Date: Thu, 30 Jun 2011 14:16:05 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1309260558-3332-1-git-send-email-stefano.stabellini@eu.citrix.com> <4E0C61DF.2050606@suse.de> In-Reply-To: <4E0C61DF.2050606@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3] xen: implement unplug protocol in xen_platform List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: xen-devel@lists.xensource.com, mst@redhat.com, stefano.stabellini@eu.citrix.com, qemu-devel@nongnu.org, armbru@redhat.com, anthony.perard@citrix.com Am 30.06.2011 13:45, schrieb Alexander Graf: > On 06/28/2011 01:29 PM, stefano.stabellini@eu.citrix.com wrote: >> From: Stefano Stabellini >> >> The unplug protocol is necessary to support PV drivers in the guest: the >> drivers expect to be able to "unplug" emulated disks and nics before >> initializing the Xen PV interfaces. >> It is responsibility of the guest to make sure that the unplug is done >> before the emulated devices or the PV interface start to be used. >> >> We use pci_for_each_device to walk the PCI bus, identify the devices and >> disks that we want to disable and dynamically unplug them. > > $ ~/git/qemu/scripts/checkpatch.pl * > ERROR: space required after that ',' (ctx:VxV) > #158: FILE: hw/ide/piix.c:240: > + },{ > ^ > > total: 1 errors, 0 warnings, 130 lines checked I think checkpatch.pl should be fixed in this case. We do have this pattern all over the place in qemu and I don't see why it's bad. > I definitely want to see an ack from Kevin here first though. The approach looks good enough for me, unless someone has a better idea on how to do it cleanly. I commented on the implementation. Kevin