From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59382) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QcGbQ-0008Ei-U7 for qemu-devel@nongnu.org; Thu, 30 Jun 2011 08:44:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QcGbP-0007aC-Fd for qemu-devel@nongnu.org; Thu, 30 Jun 2011 08:44:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15860) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QcGbP-0007a2-1p for qemu-devel@nongnu.org; Thu, 30 Jun 2011 08:44:15 -0400 Message-ID: <4E0C7047.3010909@redhat.com> Date: Thu, 30 Jun 2011 14:47:03 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1308927034-10209-1-git-send-email-stefano.stabellini@eu.citrix.com> <1308927034-10209-2-git-send-email-stefano.stabellini@eu.citrix.com> <4E0C6263.20908@suse.de> In-Reply-To: <4E0C6263.20908@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] xen_disk: treat "aio" as "raw" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org, stefano.stabellini@eu.citrix.com Am 30.06.2011 13:47, schrieb Alexander Graf: > On 06/24/2011 04:50 PM, stefano.stabellini@eu.citrix.com wrote: >> From: Stefano Stabellini >> >> Sometimes the toolstack uses "aio" without an additional format >> identifier, in such cases use "raw". > > Shouldn't this rather be a patch to the toolstack then? We do automatic > file format recognition as default. I find magical "aio equals raw" > subtleties rather unintuitive. The asynchronous raw blktap driver is (was?) called "aio", so I guess it's to stay compatible with that. Has always been this way in Xen (and has always been confusing). As long as it stays in xen_disk.c, I don't really mind... Kevin