From: Alexander Graf <agraf@suse.de>
To: stefano.stabellini@eu.citrix.com
Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3] xen_disk: cope with missing xenstore "params" node
Date: Thu, 30 Jun 2011 17:11:06 +0200 [thread overview]
Message-ID: <4E0C920A.8030308@suse.de> (raw)
In-Reply-To: <1309187401-27685-1-git-send-email-stefano.stabellini@eu.citrix.com>
On 06/27/2011 05:10 PM, stefano.stabellini@eu.citrix.com wrote:
> From: Stefano Stabellini<stefano.stabellini@eu.citrix.com>
>
> When disk is a cdrom and the drive is empty the "params" node in
> xenstore might be missing completely: cope with it instead of
> segfaulting.
>
>
> Updated in v2:
>
> - actually removed the strchr(blkdev->params, ':') that caused the
> segfault;
>
> - free all the allocated strings from xenstore before returning;
>
>
> Updated in v3:
>
> - set blkdev fields to NULL after free'ing them.
Thanks, applied to xen-next branch.
Alex
prev parent reply other threads:[~2011-06-30 15:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-27 15:10 [Qemu-devel] [PATCH v3] xen_disk: cope with missing xenstore "params" node stefano.stabellini
2011-06-30 15:11 ` Alexander Graf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0C920A.8030308@suse.de \
--to=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).