From: Stefan Weil <weil@mail.berlios.de>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/3] block: drive_init(): Fix indentation
Date: Thu, 30 Jun 2011 22:32:37 +0200 [thread overview]
Message-ID: <4E0CDD65.3060209@mail.berlios.de> (raw)
In-Reply-To: <1309458783-12661-2-git-send-email-lcapitulino@redhat.com>
Am 30.06.2011 20:33, schrieb Luiz Capitulino:
> Some constructions in that function have broken indentation. Fix them.
>
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
> blockdev.c | 52 ++++++++++++++++++++++++++--------------------------
> 1 files changed, 26 insertions(+), 26 deletions(-)
>
Hi,
the new indentation still uses tabs. Please check your patch
using scripts/checkpatch.pl.
Regards,
Stefan W.
next prev parent reply other threads:[~2011-06-30 20:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-30 18:33 [Qemu-devel] [PATCH 0/3]: block: Small drive_init() improvements Luiz Capitulino
2011-06-30 18:33 ` [Qemu-devel] [PATCH 1/3] block: drive_init(): Fix indentation Luiz Capitulino
2011-06-30 20:32 ` Stefan Weil [this message]
2011-07-01 7:16 ` Markus Armbruster
2011-07-01 13:24 ` Luiz Capitulino
2011-06-30 18:33 ` [Qemu-devel] [PATCH 2/3] block: drive_init(): Simplify interface type setting Luiz Capitulino
2011-07-01 7:18 ` Markus Armbruster
2011-06-30 18:33 ` [Qemu-devel] [PATCH 3/3] block: drive_init(): Improve CHS setting error message Luiz Capitulino
2011-07-01 7:21 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0CDD65.3060209@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).