From: Kevin Wolf <kwolf@redhat.com>
To: Fam Zheng <famcool@gmail.com>
Cc: stefanha@gmail.com, qemu-devel@nongnu.org, hch@lst.de
Subject: Re: [Qemu-devel] [PATCH v6 05/12] VMDK: add field BDRVVmdkState.desc_offset
Date: Fri, 01 Jul 2011 15:08:09 +0200 [thread overview]
Message-ID: <4E0DC6B9.8060409@redhat.com> (raw)
In-Reply-To: <1309496142-14228-6-git-send-email-famcool@gmail.com>
Am 01.07.2011 06:55, schrieb Fam Zheng:
> There are several occurrence of magic number 0x200 as the descriptor
> offset within mono sparse image file. This is not the case for images
> with separate descriptor file. So a field is added to BDRVVmdkState to
> hold the correct value.
>
> Signed-off-by: Fam Zheng <famcool@gmail.com>
> ---
> block/vmdk.c | 26 ++++++++++++++++----------
> 1 files changed, 16 insertions(+), 10 deletions(-)
>
> @@ -296,7 +300,6 @@ static int vmdk_snapshot_create(const char *filename, const char *backing_file)
> ret = -errno;
> goto fail;
> }
> - /* the descriptor offset = 0x200 */
> if (lseek(p_fd, 0x200, SEEK_SET) == -1) {
> ret = -errno;
> goto fail;
Is this comment wrong or why do you remove it? I think for the newly
created image it is correct and with this patch we have an unexplained
magic 0x200 in the code.
Kevin
next prev parent reply other threads:[~2011-07-01 13:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-01 4:55 [Qemu-devel] [PATCH v6 00/12] Adding VMDK monolithic flat support Fam Zheng
2011-07-01 4:55 ` [Qemu-devel] [PATCH v6 01/12] VMDK: introduce VmdkExtent Fam Zheng
2011-07-01 12:28 ` Kevin Wolf
2011-07-01 4:55 ` [Qemu-devel] [PATCH v6 02/12] VMDK: bugfix, align offset to cluster in get_whole_cluster Fam Zheng
2011-07-01 4:55 ` [Qemu-devel] [PATCH v6 03/12] VMDK: probe for monolithicFlat images Fam Zheng
2011-07-01 4:55 ` [Qemu-devel] [PATCH v6 04/12] VMDK: separate vmdk_open by format version Fam Zheng
2011-07-01 13:02 ` Kevin Wolf
2011-07-01 13:06 ` Fam Zheng
2011-07-01 13:13 ` Kevin Wolf
2011-07-01 4:55 ` [Qemu-devel] [PATCH v6 05/12] VMDK: add field BDRVVmdkState.desc_offset Fam Zheng
2011-07-01 13:08 ` Kevin Wolf [this message]
2011-07-01 4:55 ` [Qemu-devel] [PATCH v6 06/12] VMDK: flush multiple extents Fam Zheng
2011-07-01 4:55 ` [Qemu-devel] [PATCH v6 07/12] VMDK: move 'static' cid_update flag to bs field Fam Zheng
2011-07-01 4:55 ` [Qemu-devel] [PATCH v6 08/12] VMDK: change get_cluster_offset return type Fam Zheng
2011-07-01 16:40 ` Kevin Wolf
2011-07-01 4:55 ` [Qemu-devel] [PATCH v6 09/12] VMDK: open/read/write for monolithicFlat image Fam Zheng
2011-07-01 5:23 ` Stefan Hajnoczi
2011-07-01 4:55 ` [Qemu-devel] [PATCH v6 10/12] VMDK: create different subformats Fam Zheng
2011-07-01 4:55 ` [Qemu-devel] [PATCH v6 11/12] VMDK: fix coding style Fam Zheng
2011-07-01 4:55 ` [Qemu-devel] [PATCH v6 12/12] block: add bdrv_get_allocated_file_size() operation Fam Zheng
2011-07-01 5:25 ` [Qemu-devel] [PATCH v6 00/12] Adding VMDK monolithic flat support Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0DC6B9.8060409@redhat.com \
--to=kwolf@redhat.com \
--cc=famcool@gmail.com \
--cc=hch@lst.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).