qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Alexander Graf <agraf@suse.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel@nongnu.org, kvm@vger.kernel.org,
	Stefan Haynoczi <stefanha@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] megasas: LSI Megaraid SAS emulation
Date: Sat, 02 Jul 2011 15:50:13 +0200	[thread overview]
Message-ID: <4E0F2215.4040307@suse.de> (raw)
In-Reply-To: <ACC78DEC-FEC1-41B7-BFAA-F7769F645936@suse.de>

On 07/01/2011 06:42 PM, Alexander Graf wrote:
>
> On 01.07.2011, at 17:35, Hannes Reinecke wrote:
>
>> This patch adds an emulation for the LSI Megaraid SAS 8708EM2 HBA.
>
> Have you tried to execute the current version of megasas and actually
 > do something with it? I just booted up openSUSE 11.4 rescue from DVD
 > with a megasas adapter that contained a raw file backed by tmpfs.
 > Creating a partition worked fine, but when running mkfs.ext3 and
 > mounting afterwards, the mount fails saying there is no ext3 on the disk.
>
> Sounds like data corruption to me :). I know that this used to work
 > a while back, so it might be a regression recently?
>
It worked here, in the sense that I've booted up an existing openSUSE 
11.4 installation. But I wouldn't be surprised if the degradation to use 
bounce-buffers has some flaws.

My guess here is that we have problems when the transfersizes larger as 
the internal bounce buffer.

(I probably should be putting in some more references to 'bounce 
buffers' here to alert people that using bounce buffers in SCSI is the 
best way of killing performance)
(And no, I will not getting into another dog-fight with Paul B. here.
Virtio can do without bounce buffers. AHCI can. So I fail to see why 
SCSI has to rely on bounce buffers.)

But enough of this, Yeah, bugfixing is needed here. I see what I can do.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)

  reply	other threads:[~2011-07-02 11:50 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-01 15:35 [Qemu-devel] [PATCH 0/3] [v5] Megasas HBA Emulation Hannes Reinecke
2011-07-01 15:35 ` [Qemu-devel] [PATCH 1/3] iov: Update parameter usage in iov_(to|from)_buf() Hannes Reinecke
2011-07-01 15:35   ` [Qemu-devel] [PATCH 2/3] scsi: Add 'hba_private' to SCSIRequest Hannes Reinecke
2011-07-01 15:35     ` [Qemu-devel] [PATCH 3/3] megasas: LSI Megaraid SAS emulation Hannes Reinecke
2011-07-01 16:42       ` Alexander Graf
2011-07-02 13:50         ` Hannes Reinecke [this message]
2011-07-02 12:28           ` Alexander Graf
2011-07-03 14:36           ` Paolo Bonzini
2011-07-04  6:13             ` Hannes Reinecke
2011-07-04  6:34               ` Paolo Bonzini
2011-07-04  7:26                 ` Hannes Reinecke
2011-07-04 10:29                   ` Paolo Bonzini
2011-07-04 12:52                     ` Hannes Reinecke
2011-07-04 12:56                       ` Paolo Bonzini
2011-07-02 16:14       ` Stefan Hajnoczi
2011-07-04  8:37         ` Hannes Reinecke
2011-07-01 15:57     ` [Qemu-devel] [PATCH 2/3] scsi: Add 'hba_private' to SCSIRequest Paolo Bonzini
2011-07-01 16:19   ` [Qemu-devel] [PATCH 1/3] iov: Update parameter usage in iov_(to|from)_buf() Alexander Graf
  -- strict thread matches above, loose matches on Subject: below --
2011-07-01  7:42 [Qemu-devel] [PATCH 0/3] [v4] Megasas HBA emulation Hannes Reinecke
2011-07-01  7:42 ` [Qemu-devel] [PATCH 1/3] iov: Add 'offset' parameter to iov_to_buf() Hannes Reinecke
2011-07-01  7:42   ` [Qemu-devel] [PATCH 2/3] scsi: replace 'tag' with 'hba_private' pointer Hannes Reinecke
2011-07-01  7:42     ` [Qemu-devel] [PATCH 3/3] megasas: LSI Megaraid SAS emulation Hannes Reinecke
2011-07-01  9:16       ` Alexander Graf
2011-07-03  8:09         ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E0F2215.4040307@suse.de \
    --to=hare@suse.de \
    --cc=agraf@suse.de \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).