From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:60035)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1QdNMB-0002qD-CU
	for qemu-devel@nongnu.org; Sun, 03 Jul 2011 10:09:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1QdNMA-0004y6-AL
	for qemu-devel@nongnu.org; Sun, 03 Jul 2011 10:09:07 -0400
Received: from mail-wy0-f173.google.com ([74.125.82.173]:65436)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1QdNMA-0004xz-5u
	for qemu-devel@nongnu.org; Sun, 03 Jul 2011 10:09:06 -0400
Received: by wyf28 with SMTP id 28so3435757wyf.4
	for <qemu-devel@nongnu.org>; Sun, 03 Jul 2011 07:09:04 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4E1077FD.9050001@redhat.com>
Date: Sun, 03 Jul 2011 16:09:01 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <4E0CA885.2050308@siemens.com>	<BANLkTi=Unfpkty5TYVUvJEBp1hzbN4du=g@mail.gmail.com>	<BANLkTimW27g3rE4a30vr1T10XccQEAi+sA@mail.gmail.com>	<4E0ECDDB.9030001@web.de>	<CAAu8pHuwnWf8njsyZEyTdK9zBoOYaHd7XJhn_6McVUPvDu7Hog@mail.gmail.com>
	<4E0EE837.1000605@web.de>
In-Reply-To: <4E0EE837.1000605@web.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] tcg: Reload local variables after return
	from longjmp
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, TeLeMan <geleman@gmail.com>, qemu-devel <qemu-devel@nongnu.org>

On 07/02/2011 11:43 AM, Jan Kiszka wrote:
>   static const char *pch;
> +static char *saved_key;
>   static jmp_buf expr_env;
>
>   #define MD_TLONG 0
> @@ -4254,8 +4255,11 @@ static const mon_cmd_t *monitor_parse_command(Monitor *mon,
>                       }
>                       typestr++;
>                   }
> -                if (get_expr(mon,&val,&p))
> +                saved_key = key;
> +                if (get_expr(mon,&val,&p)) {
> +                    key = saved_key;
>                       goto fail;
> +                }

Please make saved_key a volatile local instead.

Paolo