* [Qemu-devel] [PATCH] qxl: make sure primary surface is saved on migration
@ 2011-07-04 10:58 Yonit Halperin
2011-07-04 11:09 ` Gerd Hoffmann
0 siblings, 1 reply; 2+ messages in thread
From: Yonit Halperin @ 2011-07-04 10:58 UTC (permalink / raw)
To: qemu-devel; +Cc: spice-devel, Yonit Halperin, kraxel
---
hw/qxl.c | 9 ++++++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index 2bb36c6..9fdeffb 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -1165,11 +1165,14 @@ static void qxl_vm_change_state_handler(void *opaque, int running, int reason)
qemu_spice_vm_change_state_handler(&qxl->ssd, running, reason);
if (!running && qxl->mode == QXL_MODE_NATIVE) {
- /* dirty all vram (which holds surfaces) to make sure it is saved */
+ /* dirty all vram (which holds surfaces) and devram (primary surface)
+ * to make sure they are saved */
/* FIXME #1: should go out during "live" stage */
/* FIXME #2: we only need to save the areas which are actually used */
- ram_addr_t addr = qxl->vram_offset;
- qxl_set_dirty(addr, addr + qxl->vram_size);
+ ram_addr_t vram_addr = qxl->vram_offset;
+ ram_addr_t devram_addr = qxl->vga.vram_offset;
+ qxl_set_dirty(vram_addr, vram_addr + qxl->vram_size);
+ qxl_set_dirty(devram_addr, devram_addr + qxl->vga.vram_size);
}
}
--
1.7.4.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] qxl: make sure primary surface is saved on migration
2011-07-04 10:58 [Qemu-devel] [PATCH] qxl: make sure primary surface is saved on migration Yonit Halperin
@ 2011-07-04 11:09 ` Gerd Hoffmann
0 siblings, 0 replies; 2+ messages in thread
From: Gerd Hoffmann @ 2011-07-04 11:09 UTC (permalink / raw)
To: Yonit Halperin; +Cc: spice-devel, qemu-devel
Hi,
> + qxl_set_dirty(devram_addr, devram_addr + qxl->vga.vram_size);
It is enougth to dirty the surface0 area.
Otherwise the patch looks fine.
cheers,
Gerd
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-07-04 11:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-04 10:58 [Qemu-devel] [PATCH] qxl: make sure primary surface is saved on migration Yonit Halperin
2011-07-04 11:09 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).