From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:43536)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Qdha8-0001lu-FM
	for qemu-devel@nongnu.org; Mon, 04 Jul 2011 07:44:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Qdha4-0006xG-NL
	for qemu-devel@nongnu.org; Mon, 04 Jul 2011 07:44:51 -0400
Received: from mx1.redhat.com ([209.132.183.28]:36237)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Qdha4-0006wp-57
	for qemu-devel@nongnu.org; Mon, 04 Jul 2011 07:44:48 -0400
Message-ID: <4E11A7AB.6080401@redhat.com>
Date: Mon, 04 Jul 2011 13:44:43 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1309779051-26370-1-git-send-email-yhalperi@redhat.com>
In-Reply-To: <1309779051-26370-1-git-send-email-yhalperi@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv2] qxl: make sure primary surface is saved
	on migration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Yonit Halperin <yhalperi@redhat.com>
Cc: spice-devel@lists.freedesktop.org, qemu-devel@nongnu.org

   Hi,

> +        qxl_set_dirty(devram_addr, devram_addr + qxl->rom->surface0_area_size);

s/rom/shadow_rom/, then it is perfect.  rom points directly to guest 
memory, better don't trust that.

cheers,
   Gerd