From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:55173)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chouteau@adacore.com>) id 1Qe6Xu-0001dy-DI
	for qemu-devel@nongnu.org; Tue, 05 Jul 2011 10:24:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <chouteau@adacore.com>) id 1Qe6Xs-0005qI-Gu
	for qemu-devel@nongnu.org; Tue, 05 Jul 2011 10:24:14 -0400
Received: from mel.act-europe.fr ([194.98.77.210]:45327)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chouteau@adacore.com>) id 1Qe6Xr-0005pz-QN
	for qemu-devel@nongnu.org; Tue, 05 Jul 2011 10:24:11 -0400
Message-ID: <4E131E86.7080902@adacore.com>
Date: Tue, 05 Jul 2011 16:24:06 +0200
From: Fabien Chouteau <chouteau@adacore.com>
MIME-Version: 1.0
References: <1309178511-20027-1-git-send-email-chouteau@adacore.com>	<BANLkTimbSmJxn6QZNbw4uE8Fp0gQt6gocQ@mail.gmail.com>	<4E08925F.3030605@adacore.com>	<BANLkTimhvpiLadfrus+YefoH5oHBAqOK6w@mail.gmail.com>	<4E08ABF4.1010206@adacore.com>	<BANLkTi=bpWMcN1LQK-uyrW7BTyPwsf_SVw@mail.gmail.com>	<4E099A15.4050004@adacore.com>	<BANLkTikLwOzo_akmzV+jLYsSVDpi7oGsjw@mail.gmail.com>
	<4E0C360B.5060406@adacore.com>
In-Reply-To: <4E0C360B.5060406@adacore.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Make SLIRP Ethernet packets size to 64
 bytes minimuma
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org

On 30/06/2011 10:38, Fabien Chouteau wrote:
> On 28/06/2011 15:15, Stefan Hajnoczi wrote:
>> On Tue, Jun 28, 2011 at 10:08 AM, Fabien Chouteau <chouteau@adacore.com> wrote:
>>> On 28/06/2011 10:34, Stefan Hajnoczi wrote:
>>>> This patch doesn't hurt but we'd be just as well off without it.
>>>>
>>>> Did you do this to fix a bug?  If so, then something else in QEMU
>>>> needs to be fixed, not slirp.
>>>
>>> When Qemu generates bad Ethernet frames, I think it's a bug.
>>>
>>> And again, this is the extension of a previous patch. If this patch is not
>>> valid then we should revert the first, it's also a question of consistency.
>>
>> IMO the previous patch is not necessary either.
>>
>> Since there is no net subsystem maintainer who can help decide which
>> way to go, I'm going to back off from this issue.  Please go ahead.
>>
> 
> OK thanks.
> 
> Any other comments?
> 

This patch got no further comments, can it be applied please?

thanks,

-- 
Fabien Chouteau