From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39091) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QePHS-0005Iq-Ed for qemu-devel@nongnu.org; Wed, 06 Jul 2011 06:24:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QePHQ-000266-JJ for qemu-devel@nongnu.org; Wed, 06 Jul 2011 06:24:29 -0400 Received: from mail-wy0-f173.google.com ([74.125.82.173]:46250) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QePHQ-00025t-3e for qemu-devel@nongnu.org; Wed, 06 Jul 2011 06:24:28 -0400 Received: by wyf28 with SMTP id 28so5259794wyf.4 for ; Wed, 06 Jul 2011 03:24:27 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4E1437D8.3030103@redhat.com> Date: Wed, 06 Jul 2011 12:24:24 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1309883290-17595-1-git-send-email-agraf@suse.de> <1309883290-17595-2-git-send-email-agraf@suse.de> <88EE018B-0308-48B5-80F8-B83D744E41A2@suse.de> <484E8730-8686-4FBE-9C50-2211C9C4E929@suse.de> In-Reply-To: <484E8730-8686-4FBE-9C50-2211C9C4E929@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/9] exec: add endian specific phys ld/st functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Blue Swirl , "qemu-devel@nongnu.org Developers" > diff --git a/exec.c b/exec.c > index 5f2f87e..f281ba4 100644 > --- a/exec.c > +++ b/exec.c > @@ -4127,7 +4127,8 @@ void cpu_physical_memory_unmap(void *buffer, target_phys_addr_t len, > } > > /* warning: addr must be aligned */ > -uint32_t ldl_phys(target_phys_addr_t addr) > +static inline uint32_t ldl_phys_internal(target_phys_addr_t addr, > + enum device_endian endian) You probably need the __always_inline__ attribute to really convince GCC to inline this. Paolo