From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:50658)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QejBU-0002ys-5k
	for qemu-devel@nongnu.org; Thu, 07 Jul 2011 03:39:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QejBS-0008Nw-Sm
	for qemu-devel@nongnu.org; Thu, 07 Jul 2011 03:39:39 -0400
Received: from mx1.redhat.com ([209.132.183.28]:22991)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QejBS-0008No-Cf
	for qemu-devel@nongnu.org; Thu, 07 Jul 2011 03:39:38 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p677dbJV030255
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 7 Jul 2011 03:39:37 -0400
Message-ID: <4E1562B6.9030500@redhat.com>
Date: Thu, 07 Jul 2011 09:39:34 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1309954766-9728-1-git-send-email-alevy@redhat.com>
	<1309954766-9728-6-git-send-email-alevy@redhat.com>
In-Reply-To: <1309954766-9728-6-git-send-email-alevy@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qxl: move qemu_spice_add_memslot call out
	of qxl_add_memslot
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alon Levy <alevy@redhat.com>
Cc: yhalperi@redhat.com, qemu-devel@nongnu.org

   Hi,

> -static void qxl_add_memslot(PCIQXLDevice *d, uint32_t slot_id, uint64_t delta)
> +static void qxl_add_memslot(PCIQXLDevice *d, uint32_t slot_id, uint64_t delta,
> +                            QXLDevMemSlot *memslot)

> -        qxl_add_memslot(d, val, 0);
> +        qxl_add_memslot(d, val, 0,&memslot);
> +        qemu_spice_add_memslot(&d->ssd,&memslot);

Do we still need this and the simliar patches?  Given that we don't call 
qemu_spice_add_memslot() from another thread any more we could just pass 
in a async flag to qxl_add_memslot().

cheers,
   Gerd