From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] Error: Fix build when qemu-common.h is not included
Date: Thu, 07 Jul 2011 11:17:15 -0500 [thread overview]
Message-ID: <4E15DC0B.7050608@linux.vnet.ibm.com> (raw)
In-Reply-To: <20110707130255.76f47cd0@doriath>
On 07/07/2011 11:02 AM, Luiz Capitulino wrote:
> Commit e4ea5e2d0e0e4c5188ab45b66f3195062ae059dc added the use of
> the macro GCC_FMT_ATTR to error.h, however qemu-common.h is not
> included by error.h
>
> This will cause a build error when files including error.h
> don't include qemu-common.h. Not an issue today because the only
> file including it is json-parser.h and it does include
> qemu-common.h, but let's fix it.
>
> Signed-off-by: Luiz Capitulino<lcapitulino@redhat.com>
> ---
> error.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/error.h b/error.h
> index 0f92a6f..6e3bd98 100644
> --- a/error.h
> +++ b/error.h
> @@ -12,7 +12,7 @@
> #ifndef ERROR_H
> #define ERROR_H
>
> -#include<stdbool.h>
> +#include "qemu-common.h"
>
> /**
> * A class representing internal errors within QEMU. An error has a string
Tested-by: Michael Roth <mdroth@linux.vnet.ibm.com>
next prev parent reply other threads:[~2011-07-07 16:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-07 16:02 [Qemu-devel] [PATCH] Error: Fix build when qemu-common.h is not included Luiz Capitulino
2011-07-07 16:17 ` Michael Roth [this message]
2011-07-07 16:50 ` Stefan Weil
2011-07-07 17:32 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E15DC0B.7050608@linux.vnet.ibm.com \
--to=mdroth@linux.vnet.ibm.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).