From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53539) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QerGU-0007eI-05 for qemu-devel@nongnu.org; Thu, 07 Jul 2011 12:17:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QerGS-0001My-2U for qemu-devel@nongnu.org; Thu, 07 Jul 2011 12:17:21 -0400 Received: from e1.ny.us.ibm.com ([32.97.182.141]:43538) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QerGR-0001MX-Il for qemu-devel@nongnu.org; Thu, 07 Jul 2011 12:17:19 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e1.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p67G57LF029082 for ; Thu, 7 Jul 2011 12:05:07 -0400 Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p67GHHJh147584 for ; Thu, 7 Jul 2011 12:17:17 -0400 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p67AHFfH004344 for ; Thu, 7 Jul 2011 04:17:15 -0600 Message-ID: <4E15DC0B.7050608@linux.vnet.ibm.com> Date: Thu, 07 Jul 2011 11:17:15 -0500 From: Michael Roth MIME-Version: 1.0 References: <20110707130255.76f47cd0@doriath> In-Reply-To: <20110707130255.76f47cd0@doriath> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Error: Fix build when qemu-common.h is not included List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel On 07/07/2011 11:02 AM, Luiz Capitulino wrote: > Commit e4ea5e2d0e0e4c5188ab45b66f3195062ae059dc added the use of > the macro GCC_FMT_ATTR to error.h, however qemu-common.h is not > included by error.h > > This will cause a build error when files including error.h > don't include qemu-common.h. Not an issue today because the only > file including it is json-parser.h and it does include > qemu-common.h, but let's fix it. > > Signed-off-by: Luiz Capitulino > --- > error.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/error.h b/error.h > index 0f92a6f..6e3bd98 100644 > --- a/error.h > +++ b/error.h > @@ -12,7 +12,7 @@ > #ifndef ERROR_H > #define ERROR_H > > -#include > +#include "qemu-common.h" > > /** > * A class representing internal errors within QEMU. An error has a string Tested-by: Michael Roth