From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:55414)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Qf69L-00065H-Kp
	for qemu-devel@nongnu.org; Fri, 08 Jul 2011 04:11:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Qf69J-00020K-OB
	for qemu-devel@nongnu.org; Fri, 08 Jul 2011 04:10:59 -0400
Received: from mx1.redhat.com ([209.132.183.28]:20793)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Qf69J-00020B-5H
	for qemu-devel@nongnu.org; Fri, 08 Jul 2011 04:10:57 -0400
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p688AtxS025665
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 8 Jul 2011 04:10:55 -0400
Message-ID: <4E16BB8D.9020007@redhat.com>
Date: Fri, 08 Jul 2011 10:10:53 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1310057455-18570-1-git-send-email-alevy@redhat.com>
	<1310057455-18570-10-git-send-email-alevy@redhat.com>
	<4E16AF1E.4020406@redhat.com>
	<20110708080043.GY20603@bow.redhat.com>
In-Reply-To: <20110708080043.GY20603@bow.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] qxl: async I/O
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org, yhalperi@redhat.com

> The above two lines change was a mistake. What about:
>
> qxl_spice_update_area_async(...)
> {
> #ifdef ..
>   if (async) {
>      qxl->ssd.worker->update_area_async(...)
>   } else {
>      qxl_spice_update_area(...)
>   }
> #else
>   qxl_spice_update_area(...)
> #endif
> }

I would do

if (async) {
#if ...
   worker->foo_async()
#else
   abort() /* should hot happen */
#endif
} else {
   worker->foo
}

> yeah, I'll throw that, malloc something, cast to cookie, pass it, cast back, free.

cookie should be big enougth to store the info directly.  malloc works 
too though.

>> Doing a runtime check here is pointless, just use
>> #if SPICE_INTERFACE_QXL_MINOR>= 1
>> ...
>> #endif
> this is a runtime check - what's preventing someone from compiling with 3.1 and running with 3.0?
> that we will require a newer library version? (which I am yet to send a patch for)

Yes, thats why the minor version of the shared library needs to be raised.

cheers,
   Gerd