From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34173) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qf6EU-0007UB-T2 for qemu-devel@nongnu.org; Fri, 08 Jul 2011 04:16:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qf6ET-00032o-Gk for qemu-devel@nongnu.org; Fri, 08 Jul 2011 04:16:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38583) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qf6ET-00032d-1Y for qemu-devel@nongnu.org; Fri, 08 Jul 2011 04:16:17 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p688GG5u029001 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 8 Jul 2011 04:16:16 -0400 Message-ID: <4E16BCCD.4000001@redhat.com> Date: Fri, 08 Jul 2011 10:16:13 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1310057455-18570-1-git-send-email-alevy@redhat.com> <1310057455-18570-10-git-send-email-alevy@redhat.com> <4E16AF1E.4020406@redhat.com> <20110708081201.GA20603@bow.redhat.com> In-Reply-To: <20110708081201.GA20603@bow.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] qxl: async I/O List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, yhalperi@redhat.com > btw, I'm looking at "#if.*MINOR" code like > > #if SPICE_INTERFACE_CORE_MINOR>= 3 > > (ui/spice-core.c) > > Shouldn't that be checking the MAJOR as well? major changing means a incompatible change. I doubt we ever will do that. But if you feel better checking that it probably should just be a #if SPICE_INTERFACE_CORE_MAJOR != 1 #error incompatible spice core interface #endif at the top of the file. cheers, Gerd