From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QfEWT-0001wr-5w for qemu-devel@nongnu.org; Fri, 08 Jul 2011 13:07:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QfEWR-0005bc-Ll for qemu-devel@nongnu.org; Fri, 08 Jul 2011 13:07:25 -0400 Received: from mail-yi0-f45.google.com ([209.85.218.45]:60768) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QfEWR-0005bQ-Dd for qemu-devel@nongnu.org; Fri, 08 Jul 2011 13:07:23 -0400 Received: by yia25 with SMTP id 25so1029997yia.4 for ; Fri, 08 Jul 2011 10:07:22 -0700 (PDT) Message-ID: <4E173947.3050705@codemonkey.ws> Date: Fri, 08 Jul 2011 12:07:19 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1310115239-19288-1-git-send-email-kraxel@redhat.com> <1310115239-19288-2-git-send-email-kraxel@redhat.com> <4E17137A.1010308@codemonkey.ws> <4E1725EE.4080603@redhat.com> <4E172A9F.4070003@redhat.com> In-Reply-To: <4E172A9F.4070003@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/3] vmstate: add no_migrate flag to VMStateDescription List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On 07/08/2011 11:04 AM, Gerd Hoffmann wrote: > On 07/08/11 17:44, Gerd Hoffmann wrote: >> On 07/08/11 16:26, Anthony Liguori wrote: >>> register_device_unmigratable()? >> >> Wanna have a patch to zap it? > > Ah, no, we can't, for ivshmem this isn't fixed but depends on the > configuration, so a static flag in the VMStateDescription doesn't cut it. Right, but can we have some continuity at least between the two interfaces? At least make the vmstate flag 'unmigratable' or rename the function to qdev_set_no_migrate(). BTW, should this be a vmstate flag or a qdev flag? Regards, Anthony Liguori > > cheers, > Gerd >