From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Devin Nakamura <devin122@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] qemu-io: Fix if scoping bug
Date: Mon, 11 Jul 2011 15:18:02 +0200 [thread overview]
Message-ID: <4E1AF80A.7050000@redhat.com> (raw)
In-Reply-To: <CAJSP0QUpekvJK46C=gicegybDBB499ZvCrM8uYB2bGDQb40D5g@mail.gmail.com>
Am 11.07.2011 11:47, schrieb Stefan Hajnoczi:
> On Mon, Jul 11, 2011 at 6:25 AM, Devin Nakamura <devin122@gmail.com> wrote:
>> diff --git a/qemu-io.c b/qemu-io.c
>> index e484f40..85cfe27 100644
>> --- a/qemu-io.c
>> +++ b/qemu-io.c
>> @@ -449,7 +449,7 @@ static int read_f(int argc, char **argv)
>> return 0;
>> }
>>
>> - if (!pflag)
>> + if (!pflag) {
>> if (offset & 0x1ff) {
>> printf("offset %" PRId64 " is not sector aligned\n",
>> offset);
>
> Wait, this is not enough. The indentation and curlies are so broken
> here :). The if (offset & 0x1ff) statement needs a closing curly.
It's actually there, patch 1 already contains it. Breaks bisectability,
of course.
Kevin
next prev parent reply other threads:[~2011-07-11 13:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-11 5:25 [Qemu-devel] [PATCH 1/2] qemu-io: Fix formatting Devin Nakamura
2011-07-11 5:25 ` [Qemu-devel] [PATCH 2/2] qemu-io: Fix if scoping bug Devin Nakamura
2011-07-11 9:47 ` Stefan Hajnoczi
2011-07-11 13:18 ` Kevin Wolf [this message]
2011-07-11 13:18 ` Stefan Hajnoczi
2011-07-11 15:20 ` [Qemu-devel] [PATCH v3 " Devin Nakamura
2011-07-12 12:59 ` Kevin Wolf
2011-07-11 13:21 ` [Qemu-devel] [PATCH 1/2] qemu-io: Fix formatting Kevin Wolf
2011-07-11 15:22 ` [Qemu-devel] [PATCH v3 " Devin Nakamura
-- strict thread matches above, loose matches on Subject: below --
2011-06-11 3:29 [Qemu-devel] [PATCH 2/2] qemu-io: Fix if scoping bug Devin Nakamura
2011-06-14 8:42 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E1AF80A.7050000@redhat.com \
--to=kwolf@redhat.com \
--cc=devin122@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).