From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:54735)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1QgGKO-0007lK-Fm
	for qemu-devel@nongnu.org; Mon, 11 Jul 2011 09:15:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1QgGKM-0008DY-SF
	for qemu-devel@nongnu.org; Mon, 11 Jul 2011 09:15:12 -0400
Received: from mx1.redhat.com ([209.132.183.28]:15334)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1QgGKM-0008DK-BF
	for qemu-devel@nongnu.org; Mon, 11 Jul 2011 09:15:10 -0400
Message-ID: <4E1AF80A.7050000@redhat.com>
Date: Mon, 11 Jul 2011 15:18:02 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <d93a44de6e1bef9ecb98509ee7ab2bf3e06c8d44.1310361865.git.devin122@gmail.com>	<004f3f00feb28f2d8f9f7c837e06a8fd414dfd73.1310361865.git.devin122@gmail.com>
	<CAJSP0QUpekvJK46C=gicegybDBB499ZvCrM8uYB2bGDQb40D5g@mail.gmail.com>
In-Reply-To: <CAJSP0QUpekvJK46C=gicegybDBB499ZvCrM8uYB2bGDQb40D5g@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/2] qemu-io: Fix if scoping bug
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Devin Nakamura <devin122@gmail.com>, qemu-devel@nongnu.org

Am 11.07.2011 11:47, schrieb Stefan Hajnoczi:
> On Mon, Jul 11, 2011 at 6:25 AM, Devin Nakamura <devin122@gmail.com> wrote:
>> diff --git a/qemu-io.c b/qemu-io.c
>> index e484f40..85cfe27 100644
>> --- a/qemu-io.c
>> +++ b/qemu-io.c
>> @@ -449,7 +449,7 @@ static int read_f(int argc, char **argv)
>>         return 0;
>>     }
>>
>> -    if (!pflag)
>> +    if (!pflag) {
>>         if (offset & 0x1ff) {
>>             printf("offset %" PRId64 " is not sector aligned\n",
>>                    offset);
> 
> Wait, this is not enough.  The indentation and curlies are so broken
> here :).  The if (offset & 0x1ff) statement needs a closing curly.

It's actually there, patch 1 already contains it. Breaks bisectability,
of course.

Kevin