Re: [Qemu-devel] [PATCH v3] QMP: add snapshot_blkdev command

[Jes Sorensen <Jes.Sorensen@redhat.com>]

On 07/11/11 22:24, Luiz Capitulino wrote:
> On Mon, 11 Jul 2011 20:01:09 +0200
> Jes.Sorensen@redhat.com wrote:
> 
>> > From: Jes Sorensen <Jes.Sorensen@redhat.com>
>> > 
>> > Add QMP bits for snapshot_blkdev command. This is the same as
>> > snapshot_blkdev in the human monitor. The command is synchronous.
>> > 
>> > In the future async commands and or a break down of the functionality
>> > into multiple commands might be added.
>> > 
>> > Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
>> > ---
>> >  qmp-commands.hx |   35 +++++++++++++++++++++++++++++++++++
>> >  1 files changed, 35 insertions(+), 0 deletions(-)
>> > 
>> > diff --git a/qmp-commands.hx b/qmp-commands.hx
>> > index 92c5c3a..2b9f6af 100644
>> > --- a/qmp-commands.hx
>> > +++ b/qmp-commands.hx
>> > @@ -694,6 +694,41 @@ Example:
>> >  EQMP
>> >  
>> >      {
>> > +        .name       = "blockdev-snapshot-sync",
>> > +        .args_type  = "device:B,snapshot-file:s?,format:s?",
> You changed from an underline to a hyphen as I asked, but the implementation
> still expects an underline. I fixed that myself to avoid multiple submissions
> because of a small thing (also fixed the command name in the subject).
> 
> The patch I merged follows for reference. Please, test your patches before
> submitting next time.
> 
> 

Sorry that is no go, you just broke the hmp implementation - you cannot
change the hmp behavior like that.

Jes