From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:42945) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QgZFy-0002qp-M4 for qemu-devel@nongnu.org; Tue, 12 Jul 2011 05:27:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QgZFv-0002Zu-O2 for qemu-devel@nongnu.org; Tue, 12 Jul 2011 05:27:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44471) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QgZFv-0002Zh-5p for qemu-devel@nongnu.org; Tue, 12 Jul 2011 05:27:51 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6C9RntE013198 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 12 Jul 2011 05:27:49 -0400 Message-ID: <4E1C1331.6060007@redhat.com> Date: Tue, 12 Jul 2011 11:26:09 +0200 From: Jes Sorensen MIME-Version: 1.0 References: <1310407269-13203-1-git-send-email-Jes.Sorensen@redhat.com> <20110711172456.5f61adbb@doriath> <4E1B5D09.6050403@redhat.com> <20110711173546.71bdc33c@doriath> In-Reply-To: <20110711173546.71bdc33c@doriath> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3] QMP: add snapshot_blkdev command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel@nongnu.org On 07/11/11 22:35, Luiz Capitulino wrote: >> Sorry that is no go, you just broke the hmp implementation - you cannot >> > change the hmp behavior like that. > HMP uses positional arguments, so changing argument names makes no > difference. And, apart from some exceptions, it's not an stable interface, > anyway... > I guess you're right about the naming not affecting the hmp interface. However hmp is far more usable to end users than qmp, so yes it does matter not to change the interface at random. Jes