From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40442) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QgtaV-0004Ak-4J for qemu-devel@nongnu.org; Wed, 13 Jul 2011 03:10:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QgtaS-0004EQ-VF for qemu-devel@nongnu.org; Wed, 13 Jul 2011 03:10:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42440) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QgtaS-0004Do-9G for qemu-devel@nongnu.org; Wed, 13 Jul 2011 03:10:24 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6D7AMEt016461 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 13 Jul 2011 03:10:22 -0400 Message-ID: <4E1D44DB.5090803@redhat.com> Date: Wed, 13 Jul 2011 09:10:19 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1310478932-25370-1-git-send-email-alevy@redhat.com> <1310478932-25370-14-git-send-email-alevy@redhat.com> In-Reply-To: <1310478932-25370-14-git-send-email-alevy@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy Cc: qemu-devel@nongnu.org On 07/12/11 15:55, Alon Levy wrote: > Later the save will happen asynchronously on surface_updated callback. Hmm. I can see why you are doing that. It makes the file being written *after* the monitor command finishes though, which I think we should avoid. cheers, Gerd