From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: agl@linux.vnet.ibm.com, Jes.Sorensen@redhat.com,
qemu-devel@nongnu.org, lcapitulino@redhat.com,
aliguori@linux.vnet.ibm.com, pmyers@redhat.com
Subject: Re: [Qemu-devel] [QAPI+QGA 3/3] QEMU Guest Agent (virtagent) v6
Date: Wed, 13 Jul 2011 12:51:18 -0500 [thread overview]
Message-ID: <4E1DDB16.1060005@linux.vnet.ibm.com> (raw)
In-Reply-To: <20110713131458.GE22414@redhat.com>
On 07/13/2011 08:14 AM, Daniel P. Berrange wrote:
> On Tue, Jul 05, 2011 at 08:21:36AM -0500, Michael Roth wrote:
>> BUILD/USAGE
>>
>> build:
>> ./configure --target-list=x86_64-softmmu
>> make
>> make qemu-ga #should be built on|for target guest
>>
>> start guest:
>> qemu \
>> -drive file=/home/mdroth/vm/rhel6_64_base.raw,snapshot=off,if=virtio \
>> -net nic,model=virtio,macaddr=52:54:00:12:34:00 \
>> -net tap,script=/etc/qemu-ifup \
>> -vnc :1 -m 1024 --enable-kvm \
>> -chardev socket,path=/tmp/qga.sock,server,nowait,id=qga \
>> -device virtio-serial \
>> -device virtserialport,chardev=qga,name=qga"
>>
>> use guest agent:
>> ./qemu-ga -h
>> ./qemu-ga -c virtio-serial -p /dev/virtio-ports/qga
>
> Have we documented any naming convention for virtio serial ports yet ?
> For both Matahari, and libguestfs we've followed the reverse domain
> name style naming adopted by things like DBus and AMQP, or language
> package namespaces. eg
>
> org.libguestfs.channel.0
> org.apache.qpid.matahari.0
>
> The '.0' is just in case we find we need to add further channels
> for each agent later with different usage.
>
> I think this would be a good general naming convention to recommend
> to app developers in order to avoid naming clashes, and thus think
> that the QEMU guest agent should use a channel name prefixed with
> 'org.qemu.' eg perhaps
>
> ...
> -device virtserialport,chardev=qga,name=org.qemu.guestagent.0"
> ...
>
> ./qemu-ga -c virtio-serial -p /dev/virtio-ports/org.qemu.guestagent.0
>
> Regards,
> Daniel
Hi Daniel,
If you don't specify the -p option explicitly, qemu-ga will look for
"/dev/virtio-ports/org.qemu.guest_agent"
Adding ".0" would be useful though, so I'll make
"/dev/virtio-ports/org.qemu.guest_agent.0" the default, and update any
surrounding documentation to encourage that convention.
next prev parent reply other threads:[~2011-07-13 17:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-05 13:21 [Qemu-devel] [QAPI+QGA 3/3] QEMU Guest Agent (virtagent) v6 Michael Roth
2011-07-05 13:21 ` [Qemu-devel] [PATCH v6 1/4] guest agent: command state class Michael Roth
2011-07-08 14:25 ` Luiz Capitulino
2011-07-08 20:22 ` Michael Roth
2011-07-05 13:21 ` [Qemu-devel] [PATCH v6 2/4] guest agent: qemu-ga daemon Michael Roth
2011-07-06 0:34 ` Michael Roth
2011-07-08 14:36 ` Luiz Capitulino
2011-07-08 21:12 ` Michael Roth
2011-07-05 13:21 ` [Qemu-devel] [PATCH v6 3/4] guest agent: add guest agent commands schema file Michael Roth
2011-07-08 15:08 ` Luiz Capitulino
2011-07-08 21:42 ` Michael Roth
2011-07-05 13:21 ` [Qemu-devel] [PATCH v6 4/4] guest agent: add guest agent RPCs/commands Michael Roth
2011-07-08 15:14 ` Luiz Capitulino
2011-07-11 20:11 ` Michael Roth
2011-07-11 21:12 ` Luiz Capitulino
2011-07-11 23:11 ` Michael Roth
2011-07-12 14:15 ` Luiz Capitulino
2011-07-12 15:44 ` Michael Roth
2011-07-12 16:30 ` Luiz Capitulino
2011-07-13 13:14 ` [Qemu-devel] [QAPI+QGA 3/3] QEMU Guest Agent (virtagent) v6 Daniel P. Berrange
2011-07-13 17:51 ` Michael Roth [this message]
2011-07-14 2:53 ` Zhi Yong Wu
2011-07-14 12:55 ` Luiz Capitulino
2011-07-14 13:53 ` Zhi Yong Wu
2011-07-14 14:04 ` Michael Roth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E1DDB16.1060005@linux.vnet.ibm.com \
--to=mdroth@linux.vnet.ibm.com \
--cc=Jes.Sorensen@redhat.com \
--cc=agl@linux.vnet.ibm.com \
--cc=aliguori@linux.vnet.ibm.com \
--cc=berrange@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=pmyers@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).