From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:38313) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qh3cH-0007SB-LH for qemu-devel@nongnu.org; Wed, 13 Jul 2011 13:52:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qh3cF-0005tl-Q5 for qemu-devel@nongnu.org; Wed, 13 Jul 2011 13:52:57 -0400 Received: from e6.ny.us.ibm.com ([32.97.182.146]:50244) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qh3cF-0005td-CH for qemu-devel@nongnu.org; Wed, 13 Jul 2011 13:52:55 -0400 Received: from d01relay01.pok.ibm.com (d01relay01.pok.ibm.com [9.56.227.233]) by e6.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p6DHSTDN007072 for ; Wed, 13 Jul 2011 13:28:29 -0400 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay01.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p6DHpJsg144644 for ; Wed, 13 Jul 2011 13:51:19 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p6DHpJZ0026807 for ; Wed, 13 Jul 2011 13:51:19 -0400 Message-ID: <4E1DDB16.1060005@linux.vnet.ibm.com> Date: Wed, 13 Jul 2011 12:51:18 -0500 From: Michael Roth MIME-Version: 1.0 References: <1309872100-27912-1-git-send-email-mdroth@linux.vnet.ibm.com> <20110713131458.GE22414@redhat.com> In-Reply-To: <20110713131458.GE22414@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [QAPI+QGA 3/3] QEMU Guest Agent (virtagent) v6 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: agl@linux.vnet.ibm.com, Jes.Sorensen@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, aliguori@linux.vnet.ibm.com, pmyers@redhat.com On 07/13/2011 08:14 AM, Daniel P. Berrange wrote: > On Tue, Jul 05, 2011 at 08:21:36AM -0500, Michael Roth wrote: >> BUILD/USAGE >> >> build: >> ./configure --target-list=x86_64-softmmu >> make >> make qemu-ga #should be built on|for target guest >> >> start guest: >> qemu \ >> -drive file=/home/mdroth/vm/rhel6_64_base.raw,snapshot=off,if=virtio \ >> -net nic,model=virtio,macaddr=52:54:00:12:34:00 \ >> -net tap,script=/etc/qemu-ifup \ >> -vnc :1 -m 1024 --enable-kvm \ >> -chardev socket,path=/tmp/qga.sock,server,nowait,id=qga \ >> -device virtio-serial \ >> -device virtserialport,chardev=qga,name=qga" >> >> use guest agent: >> ./qemu-ga -h >> ./qemu-ga -c virtio-serial -p /dev/virtio-ports/qga > > Have we documented any naming convention for virtio serial ports yet ? > For both Matahari, and libguestfs we've followed the reverse domain > name style naming adopted by things like DBus and AMQP, or language > package namespaces. eg > > org.libguestfs.channel.0 > org.apache.qpid.matahari.0 > > The '.0' is just in case we find we need to add further channels > for each agent later with different usage. > > I think this would be a good general naming convention to recommend > to app developers in order to avoid naming clashes, and thus think > that the QEMU guest agent should use a channel name prefixed with > 'org.qemu.' eg perhaps > > ... > -device virtserialport,chardev=qga,name=org.qemu.guestagent.0" > ... > > ./qemu-ga -c virtio-serial -p /dev/virtio-ports/org.qemu.guestagent.0 > > Regards, > Daniel Hi Daniel, If you don't specify the -p option explicitly, qemu-ga will look for "/dev/virtio-ports/org.qemu.guest_agent" Adding ".0" would be useful though, so I'll make "/dev/virtio-ports/org.qemu.guest_agent.0" the default, and update any surrounding documentation to encourage that convention.