qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Alon Levy <alevy@redhat.com>
Cc: yhalperi@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCHv4 05/11] qxl: add io_port_to_string
Date: Thu, 14 Jul 2011 10:40:36 +0200	[thread overview]
Message-ID: <4E1EAB84.1070305@redhat.com> (raw)
In-Reply-To: <1310568597-24181-6-git-send-email-alevy@redhat.com>

   Hi,

> +    case QXL_IO_UPDATE_AREA_ASYNC:
> +        return "QXL_IO_UPDATE_AREA_ASYNC";

Fails to build with old libspice-server (well, old libspice-protocol to 
be exact).  Needs #ifdef.  Using SPICE_INTERFACE_QXL_MINOR should work 
fine as the new libspice-server depends on the new spice-protocol too.

cheers,
   Gerd

  parent reply	other threads:[~2011-07-14  8:40 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-13 14:49 [Qemu-devel] [PATCHv4 00/11] async + suspend reworked Alon Levy
2011-07-13 14:49 ` [Qemu-devel] [PATCHv4 01/11] spice: add worker wrapper functions Alon Levy
2011-07-13 14:49 ` [Qemu-devel] [PATCHv4 02/11] spice: add qemu_spice_display_init_common Alon Levy
2011-07-13 14:49 ` [Qemu-devel] [PATCHv4 03/11] qxl: remove qxl_destroy_primary() Alon Levy
2011-07-14  8:33   ` Gerd Hoffmann
2011-07-14  9:27     ` Alon Levy
2011-07-13 14:49 ` [Qemu-devel] [PATCHv4 04/11] qxl: fix surface tracking & locking Alon Levy
2011-07-13 14:49 ` [Qemu-devel] [PATCHv4 05/11] qxl: add io_port_to_string Alon Levy
2011-07-14  8:37   ` Gerd Hoffmann
2011-07-14  8:52     ` Alon Levy
2011-07-14  8:40   ` Gerd Hoffmann [this message]
2011-07-13 14:49 ` [Qemu-devel] [PATCHv4 06/11] qxl: error handling fixes and cleanups Alon Levy
2011-07-14  8:42   ` Gerd Hoffmann
2011-07-13 14:49 ` [Qemu-devel] [PATCHv4 07/11] qxl: make qxl_guest_bug take variable arguments Alon Levy
2011-07-14  8:43   ` Gerd Hoffmann
2011-07-14  8:51     ` Alon Levy
2011-07-13 14:49 ` [Qemu-devel] [PATCHv4 08/11] qxl: bump pci rev Alon Levy
2011-07-14  8:44   ` Gerd Hoffmann
2011-07-13 14:49 ` [Qemu-devel] [PATCHv4 09/11] qxl: use QXL_REVISION_* Alon Levy
2011-07-14  8:46   ` Gerd Hoffmann
2011-07-14 10:06     ` Alon Levy
2011-07-13 14:49 ` [Qemu-devel] [PATCHv4 10/11] qxl: only disallow specific io's in vga mode Alon Levy
2011-07-13 14:49 ` [Qemu-devel] [PATCHv4 11/11] qxl: add QXL_IO_FLUSH_{SURFACES, RELEASE} for guest S3&S4 support Alon Levy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E1EAB84.1070305@redhat.com \
    --to=kraxel@redhat.com \
    --cc=alevy@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yhalperi@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).