From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QhHYP-0005Gn-TG for qemu-devel@nongnu.org; Thu, 14 Jul 2011 04:45:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QhHYL-0002Zp-7w for qemu-devel@nongnu.org; Thu, 14 Jul 2011 04:45:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20892) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QhHYK-0002Zh-O6 for qemu-devel@nongnu.org; Thu, 14 Jul 2011 04:45:49 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6E8jlLR024226 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 14 Jul 2011 04:45:47 -0400 Message-ID: <4E1EACB9.4040701@redhat.com> Date: Thu, 14 Jul 2011 10:45:45 +0200 From: Michal Novotny MIME-Version: 1.0 References: <1310562411-30538-1-git-send-email-minovotn@redhat.com> <4E1DA7A6.6060104@redhat.com> In-Reply-To: <4E1DA7A6.6060104@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Introduce "info migrate-times" monitor command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On 07/13/2011 04:11 PM, Paolo Bonzini wrote: > On 07/13/2011 03:06 PM, Michal Novotny wrote: >> +uint64_t time_get(const char *name, int stage); >> +void time_set(const char *name, int stage, uint64_t tv); >> +void time_add(const char *name, int stage, uint64_t tv); >> +void time_add2(const char *name, int stage, uint64_t time1, uint64_t time2); >> +uint64_t save_total_time(void); > Please inline all these instead of adding new functions. Do you mean to implement as macros? I'm trying since yesterday and it's not that simple because the variable has to be accessible from 3 files - arch_init.c, savevm.c and migration.c. So I need to figure out what file to put the variables to to make it working fine. Also, I'm thinking about extending it not just to measure save process times but also measure load process times. Thanks, Michal -- Michal Novotny , RHCE, Red Hat Virtualization | libvirt-php bindings | php-virt-control.org