From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:55777)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QhdYa-0000Iy-PO
	for qemu-devel@nongnu.org; Fri, 15 Jul 2011 04:15:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QhdYY-0000qf-LK
	for qemu-devel@nongnu.org; Fri, 15 Jul 2011 04:15:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37683)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QhdYY-0000qb-8S
	for qemu-devel@nongnu.org; Fri, 15 Jul 2011 04:15:30 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6F8FTKf004458
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 15 Jul 2011 04:15:29 -0400
Message-ID: <4E1FF71E.4090607@redhat.com>
Date: Fri, 15 Jul 2011 10:15:26 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1310670801-14687-1-git-send-email-alevy@redhat.com>
	<1310670801-14687-11-git-send-email-alevy@redhat.com>
In-Reply-To: <1310670801-14687-11-git-send-email-alevy@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv5 10/12] qxl: add QXL_IO_FLUSH_{SURFACES,
 RELEASE} for guest S3&S4 support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alon Levy <alevy@redhat.com>
Cc: yhalperi@redhat.com, qemu-devel@nongnu.org

> +#if SPICE_INTERFACE_QXL_MINOR>= 1
> +    case QXL_IO_FLUSH_RELEASE: {
> +        QXLReleaseRing *ring =&d->ram->release_ring;
> +        if (ring->prod - ring->cons + 1 == ring->num_items) {
> +            fprintf(stderr,
> +                "ERROR: no flush, full release ring [p%d,%dc]\n",
> +                ring->prod, ring->cons);
> +        }
> +        qxl_push_free_res(d, 1 /* flush */);
> +        dprint(d, 1, "QXL_IO_FLUSH_RELEASE exit (%s, s#=%d, res#=%d,%p)\n",
> +            qxl_mode_to_string(d->mode), d->guest_surfaces.count,
> +            d->num_free_res, d->last_release);
> +        break;
> +    }
> +    case QXL_IO_FLUSH_SURFACES_ASYNC:
> +        dprint(d, 1, "QXL_IO_FLUSH_SURFACES_ASYNC (%d) (%s, s#=%d, res#=%d)\n",
> +               val, qxl_mode_to_string(d->mode), d->guest_surfaces.count,
> +               d->num_free_res);
> +        qxl_spice_flush_surfaces_async(d);
> +#endif
> +        break;

The last two lines should be swapped I guess.
Doesn't harm, but looks a bit odd ...

cheers,
   Gerd