From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:45321)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QhdgX-0002Ck-W1
	for qemu-devel@nongnu.org; Fri, 15 Jul 2011 04:23:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QhdgW-000238-Fj
	for qemu-devel@nongnu.org; Fri, 15 Jul 2011 04:23:45 -0400
Received: from mx1.redhat.com ([209.132.183.28]:26548)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QhdgV-000231-Ni
	for qemu-devel@nongnu.org; Fri, 15 Jul 2011 04:23:44 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6F8NgxO010564
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 15 Jul 2011 04:23:42 -0400
Message-ID: <4E1FF90B.9070101@redhat.com>
Date: Fri, 15 Jul 2011 10:23:39 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1310670801-14687-1-git-send-email-alevy@redhat.com>
	<1310670801-14687-13-git-send-email-alevy@redhat.com>
In-Reply-To: <1310670801-14687-13-git-send-email-alevy@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv5 12/12] qxl: use QXL_REVISION_*
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alon Levy <alevy@redhat.com>
Cc: yhalperi@redhat.com, qemu-devel@nongnu.org

   Hi,

> +#if SPICE_INTERFACE_QXL_MINOR>= 1
> +    qemu_mutex_init(&qxl->async_lock);
> +    qxl->current_async = QXL_UNDEFINED_IO;
> +#endif

That surely belongs into another patch ...

> +    case QXL_REVISION_STABLE_V04: /* spice 0.4 -- qxl-1 */
> +    case QXL_REVISION_STABLE_V06: /* spice 0.6 -- qxl-2 */

I think we should just not use these defines for now.

In a year or so when the new bits are in widespread use we can raise the 
minimum required spice-server+spice-protocol versions, cleanup the ifdef 
mess and also use QXL_REVISION_STABLE_V04.

cheers,
   Gerd