From: Alexander Graf <agraf@suse.de>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] Avoid CPU endian memory accesses in devices
Date: Fri, 15 Jul 2011 22:56:45 +0200 [thread overview]
Message-ID: <4E20A98D.2030709@suse.de> (raw)
In-Reply-To: <CAAu8pHsDS+TcYkuYRE9YZot9w9LB4CZYSZSd4P2iZJAEMjffaQ@mail.gmail.com>
On 07/15/2011 10:02 PM, Blue Swirl wrote:
> On Fri, Jul 15, 2011 at 12:56 AM, Alexander Graf<agraf@suse.de> wrote:
>>
>>
>>
>> Am 14.07.2011 um 21:34 schrieb Blue Swirl<blauwirbel@gmail.com>:
>>
>>> Don't compile virtio.c in hwlib, it depends on memory accesses
>>> performed in CPU endianness.
>>>
>>> Make loads and stores in CPU endianness unavailable to devices
>>> and poison them to avoid further bugs.
>> Very nice :). Couldn't test execute it, but:
>>
>> Acked-by: Alexander Graf<agraf@suse.de>
> By the way, another way would be to change virtio to always use LE
> accesses. This would need changes to KVM on PPC and s390x. Would that
> be possible?
The code is already in Linux for quite a while, other OSs started
implementing it (Solaris) and the spec is pretty specific on fields
being in target endianness.
The virtio v2 spec will hopefully fix this, but that should end up in a
different module then :)
Alex
next prev parent reply other threads:[~2011-07-15 20:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-14 19:34 [Qemu-devel] [PATCH] Avoid CPU endian memory accesses in devices Blue Swirl
2011-07-14 21:56 ` Alexander Graf
2011-07-15 20:02 ` Blue Swirl
2011-07-15 20:56 ` Alexander Graf [this message]
2011-07-20 21:48 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E20A98D.2030709@suse.de \
--to=agraf@suse.de \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).