From: Stefan Weil <weil@mail.berlios.de>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Fix duplicate device reset
Date: Tue, 19 Jul 2011 07:56:41 +0200 [thread overview]
Message-ID: <4E251C99.9000600@mail.berlios.de> (raw)
In-Reply-To: <20110719023910.GC25737@valinux.co.jp>
Am 19.07.2011 04:39, schrieb Isaku Yamahata:
> Thank you for addressing this. Similar patches were proposed and
> weren't merged unfortunately.
>
> The reason why the qdev_register_reset() in vl.c is to keep the reset order.
> The reset for main_system_bus shouldn't registered by qbus_create_inplace().
> But the check, bus != main_system_bus, doesn't work as intended because
> main_system_bus is NULL in early qdev creation.
> So there are possible ways for the fix.
>
> - Don't care the reset order
> your patch +
> remove "if (bus != main_system_bus)" in qbus_create_inplace()
>
> - keep the reset order
> - instantiate main_system_bus early.
> So the check, bus != main_system_bus in qbus_create_inplace(), will work.
> or
> - fix the check, bus != main_system_bus in qbus_create_inplace(), somehow
>
> thanks,
Hi,
my patch does not remove sysbus_get_default(),
so the reset order is kept because main_system_bus
is instantiated by this call.
Cheers,
Stefan
next prev parent reply other threads:[~2011-07-19 5:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-18 20:22 [Qemu-devel] [PATCH] Fix duplicate device reset Stefan Weil
2011-07-19 2:39 ` Isaku Yamahata
2011-07-19 5:56 ` Stefan Weil [this message]
2011-07-19 7:22 ` Isaku Yamahata
2011-08-01 11:00 ` Isaku Yamahata
2011-08-01 20:45 ` Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E251C99.9000600@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=qemu-devel@nongnu.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).