From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46867) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjAna-0000um-RL for qemu-devel@nongnu.org; Tue, 19 Jul 2011 09:57:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QjAnY-0007R1-Kg for qemu-devel@nongnu.org; Tue, 19 Jul 2011 09:57:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1030) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjAnY-0007QR-0a for qemu-devel@nongnu.org; Tue, 19 Jul 2011 09:57:20 -0400 Message-ID: <4E258D3B.5050103@redhat.com> Date: Tue, 19 Jul 2011 16:57:15 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1310901265-32051-1-git-send-email-avi@redhat.com> <20110719135601.GA7194@redhat.com> In-Reply-To: <20110719135601.GA7194@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v4 00/58] Memory API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org On 07/19/2011 04:56 PM, Michael S. Tsirkin wrote: > On Sun, Jul 17, 2011 at 02:13:27PM +0300, Avi Kivity wrote: > > New in this version: > > MemoryRegionOps gained .old_mmio and .old_portio members, which allow > > reusing old-style callbacks with the new API. All uses were converted, > > except for eepro100.c, which uses the same MemoryRegionOps for both > > portio and mmio. Some intermediate patches do introduce dispatching > > callbacks, but they are removed later. > > > > Caveats: > > - some devices still grab a global memory region instead of inheriting > > it from their bus. Seen in the code as #include "exec-memory.h" > > Looks good to me. > > It looks like with this, users of vga_dirty_log_stop > like qxl_write_config can go away because the region can > stay registered with dirty logging enabled? Yes. You set the property once on the framebuffer, and it and all aliases are tracked whenever they or a subregion are exposed. -- error compiling committee.c: too many arguments to function