Re: [Qemu-devel] [RFC v4 00/58] Memory API

[Avi Kivity <avi@redhat.com>]

On 07/19/2011 08:01 PM, Jan Kiszka wrote:
> On 2011-07-19 15:56, Michael S. Tsirkin wrote:
> >  On Sun, Jul 17, 2011 at 02:13:27PM +0300, Avi Kivity wrote:
> >>  New in this version:
> >>    MemoryRegionOps gained .old_mmio and .old_portio members, which allow
> >>    reusing old-style callbacks with the new API.  All uses were converted,
> >>    except for eepro100.c, which uses the same MemoryRegionOps for both
> >>    portio and mmio.  Some intermediate patches do introduce dispatching
> >>    callbacks, but they are removed later.
> >>
> >>  Caveats:
> >>  - some devices still grab a global memory region instead of inheriting
> >>    it from their bus.  Seen in the code as #include "exec-memory.h"
> >
> >  Looks good to me.
> >
> >  It looks like with this, users of vga_dirty_log_stop
> >  like qxl_write_config can go away because the region can
> >  stay registered with dirty logging enabled?
>
> That was already possible with the old API, see [1]. Makes me wonder
> what will be merged first...
>

Rebasing is already not so fun for me with 78 patches and counting.  
Let's drop yours and focus of getting mine in shape, since it's a superset.

If anybody wants to help in the mostly mechanical conversions, let me a 
note.  It's usually simple, easy, and boring, but there are surprises.

-- 
error compiling committee.c: too many arguments to function