From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:55801) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjDsZ-0006MG-Hu for qemu-devel@nongnu.org; Tue, 19 Jul 2011 13:14:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QjDsX-0007eO-LT for qemu-devel@nongnu.org; Tue, 19 Jul 2011 13:14:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9738) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjDsW-0007eD-W4 for qemu-devel@nongnu.org; Tue, 19 Jul 2011 13:14:41 -0400 Message-ID: <4E25BB7A.7030105@redhat.com> Date: Tue, 19 Jul 2011 20:14:34 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1310901265-32051-1-git-send-email-avi@redhat.com> <20110719135601.GA7194@redhat.com> <4E25B85C.1030809@siemens.com> In-Reply-To: <4E25B85C.1030809@siemens.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v4 00/58] Memory API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, "Michael S. Tsirkin" On 07/19/2011 08:01 PM, Jan Kiszka wrote: > On 2011-07-19 15:56, Michael S. Tsirkin wrote: > > On Sun, Jul 17, 2011 at 02:13:27PM +0300, Avi Kivity wrote: > >> New in this version: > >> MemoryRegionOps gained .old_mmio and .old_portio members, which allow > >> reusing old-style callbacks with the new API. All uses were converted, > >> except for eepro100.c, which uses the same MemoryRegionOps for both > >> portio and mmio. Some intermediate patches do introduce dispatching > >> callbacks, but they are removed later. > >> > >> Caveats: > >> - some devices still grab a global memory region instead of inheriting > >> it from their bus. Seen in the code as #include "exec-memory.h" > > > > Looks good to me. > > > > It looks like with this, users of vga_dirty_log_stop > > like qxl_write_config can go away because the region can > > stay registered with dirty logging enabled? > > That was already possible with the old API, see [1]. Makes me wonder > what will be merged first... > Rebasing is already not so fun for me with 78 patches and counting. Let's drop yours and focus of getting mine in shape, since it's a superset. If anybody wants to help in the mostly mechanical conversions, let me a note. It's usually simple, easy, and boring, but there are surprises. -- error compiling committee.c: too many arguments to function