From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33369) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjIHH-0003oy-GI for qemu-devel@nongnu.org; Tue, 19 Jul 2011 17:56:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QjIHF-00004s-26 for qemu-devel@nongnu.org; Tue, 19 Jul 2011 17:56:31 -0400 Received: from e5.ny.us.ibm.com ([32.97.182.145]:38923) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjIHE-0008WP-Kv for qemu-devel@nongnu.org; Tue, 19 Jul 2011 17:56:28 -0400 Received: from d01relay05.pok.ibm.com (d01relay05.pok.ibm.com [9.56.227.237]) by e5.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p6JLRVBP019363 for ; Tue, 19 Jul 2011 17:27:31 -0400 Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay05.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p6JLuQnr166606 for ; Tue, 19 Jul 2011 17:56:26 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p6JHuDb5031227 for ; Tue, 19 Jul 2011 14:56:13 -0300 Message-ID: <4E25FD88.4020607@us.ibm.com> Date: Tue, 19 Jul 2011 16:56:24 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1311103418-29380-1-git-send-email-rjones@redhat.com> <1311103418-29380-2-git-send-email-rjones@redhat.com> <4E25E346.30908@us.ibm.com> <20110719205929.GE2532@amd.home.annexia.org> In-Reply-To: <20110719205929.GE2532@amd.home.annexia.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Remove debugging messages. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Richard W.M. Jones" Cc: qemu-devel@nongnu.org On 07/19/2011 03:59 PM, Richard W.M. Jones wrote: > On Tue, Jul 19, 2011 at 03:04:22PM -0500, Anthony Liguori wrote: >> On 07/19/2011 02:23 PM, Richard W.M. Jones wrote: >>> From: "Richard W.M. Jones" >>> >>> When using qemu -machine accel=kvm:tcg, if KVM is not available you >>> get a load of debugging output: >>> >>> Could not access KVM kernel module: No such file or directory >>> failed to initialize KVM: No such file or directory >>> Back to tcg accelerator. >> >> If you ask for kvm, and it can't be initialized, then shouldn't we >> alert the user about this? > > That's one way to look at it. > > Another is that libguestfs has specified that we want a "best effort". > Give me KVM, if available - great! If not, I don't really care, give > me TCG. Can't libguestfs just ignore the messages? > > The -machine option isn't expressive enough to say all these things of > course. > > BTW, it seems in 0.15 that the -machine option is now required? eg in > this case where it seems totally pointless: > > $ qemu -nographic -device \? > KVM not supported for this target > No accelerator found! Hrm, what's your HEAD because mine doesn't exhibit this behavior. Regards, Anthony Liguori > > This resulted in another bug and fix in libguestfs. > > http://git.annexia.org/?p=libguestfs.git;a=commitdiff;h=d82438431c1551610eb7d9945fa76d6387534582 > > Rich. >