From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34445) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjUpe-0007Z3-GQ for qemu-devel@nongnu.org; Wed, 20 Jul 2011 07:20:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QjUpb-0004Hj-AD for qemu-devel@nongnu.org; Wed, 20 Jul 2011 07:20:49 -0400 Received: from goliath.siemens.de ([192.35.17.28]:23792) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjUpa-0004Gb-Hf for qemu-devel@nongnu.org; Wed, 20 Jul 2011 07:20:46 -0400 Message-ID: <4E26BA09.80701@siemens.com> Date: Wed, 20 Jul 2011 13:20:41 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1310901265-32051-1-git-send-email-avi@redhat.com> <20110719135601.GA7194@redhat.com> <4E25B85C.1030809@siemens.com> <4E25BB7A.7030105@redhat.com> <4E25BF26.6080900@siemens.com> <4E268E20.5050807@redhat.com> In-Reply-To: <4E268E20.5050807@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v4 00/58] Memory API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" , "Michael S. Tsirkin" On 2011-07-20 10:13, Avi Kivity wrote: > On 07/19/2011 08:30 PM, Jan Kiszka wrote: >>> Rebasing is already not so fun for me with 78 patches and counting. >>> Let's drop yours and focus of getting mine in shape, since it's a superset. >> >> The patches series are widely orthogonal except for both killing the >> obsolete start/stop logging logic. >> >> But I don't mind rebasing over yours - if something is finally merged at >> all. > > If you post patches I'll incorporate them in my patchset. They're > available in qemu-kvm.git branch memory-region. Thanks, looking into this ATM. To allow building of that branch, this needs to be folded on one of the patches: diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c index a75a5a9..92ba3c9 100644 --- a/hw/virtio-pci.c +++ b/hw/virtio-pci.c @@ -161,7 +161,8 @@ static int virtio_pci_set_host_notifier_internal(VirtIOPCIProxy *proxy, { VirtQueue *vq = virtio_get_queue(proxy->vdev, n); EventNotifier *notifier = virtio_queue_get_host_notifier(vq); - int r; + int r = 0; + if (assign) { r = event_notifier_init(notifier, 1); if (r < 0) { Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux