From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:55512)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QjWF9-0005yA-TM
	for qemu-devel@nongnu.org; Wed, 20 Jul 2011 08:51:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QjWF8-0001OU-3o
	for qemu-devel@nongnu.org; Wed, 20 Jul 2011 08:51:15 -0400
Received: from mx1.redhat.com ([209.132.183.28]:52115)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QjWF7-0001OP-Kl
	for qemu-devel@nongnu.org; Wed, 20 Jul 2011 08:51:13 -0400
Message-ID: <4E26CF34.3060708@redhat.com>
Date: Wed, 20 Jul 2011 14:51:00 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1311156579-9814-1-git-send-email-kraxel@redhat.com>	<1311156579-9814-3-git-send-email-kraxel@redhat.com>
	<CAFEAcA9dxgLnzps++WQDG6N896-80-yXSqjwZbVe0MEMb+qPqA@mail.gmail.com>
In-Reply-To: <CAFEAcA9dxgLnzps++WQDG6N896-80-yXSqjwZbVe0MEMb+qPqA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/9] vmstate: complain about devices
 without vmstate
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org

On 07/20/11 14:40, Peter Maydell wrote:
> On 20 July 2011 11:09, Gerd Hoffmann<kraxel@redhat.com>  wrote:
>> --- a/hw/qdev.c
>> +++ b/hw/qdev.c
>> @@ -283,7 +283,12 @@ int qdev_init(DeviceState *dev)
>>          qdev_free(dev);
>>          return rc;
>>      }
>> -    if (dev->info->vmsd) {
>> +    if (dev->info->vmsd == NULL) {
>> +        /* TODO: fixup qemu source code, then make this an assert() */
>> +        error_report("WARNING: device %s has no vmstate\n", dev->info->name);
>> +    } else if (dev->info->vmsd == VMSD_NONE) {
>> +        /* device doesn't need vmstate */;
>> +    } else {
>
> I would prefer it if we didn't add this sort of targeted-at-qemu-developers
> warning unless there was a reasonable period of time before the next release
> where devices which provoke the warning message can be fixed. In particular,
> should we postpone putting in the warning message until after 0.15 branches?

Agree, makes sense to postpone that one to 0.16-devel, otherwise we'll 
just bug the users for no reason.

Pushed migration.2 branch with that patch dropped.

cheers,
   Gerd