From: Kevin Wolf <kwolf@redhat.com>
To: Frediano Ziglio <freddy77@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH 0/5] Coroutines cleanup
Date: Wed, 20 Jul 2011 15:03:39 +0200 [thread overview]
Message-ID: <4E26D22B.1020606@redhat.com> (raw)
In-Reply-To: <1311148624-5640-1-git-send-email-freddy77@gmail.com>
Am 20.07.2011 09:56, schrieb Frediano Ziglio:
> These patches mostly cleanup some AIO code using coroutines.
> These patches apply to Kevin's repository, branch coroutine-block.
> Mostly they use stack instead of allocated AIO structure.
I think your changes generally make sense as an example of how to
convert stuff to coroutines.
The thing that I'm not quite sure about is whether we should do it in
qcow1, which isn't frequently used and gets relatively little testing.
My main focus with qcow1 is keeping things working and maybe fixing
serious bugs. Code cleanups are always a (small, but not negligible)
risk of breaking things.
Anyway, I'm not totally opposed to merging this, but you really need to
improve the commit messages. First thing is that the subject should
start with the subsystem name ("qcow: Allocate AIOCB on stack"). I'm
also sure that you can be more precise than "more stack work". Please
use some more lines in the commit message to explain in more detail what
you're changing and ideally also why you're doing it.
Kevin
prev parent reply other threads:[~2011-07-20 13:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 7:56 [Qemu-devel] [RFC PATCH 0/5] Coroutines cleanup Frediano Ziglio
2011-07-20 7:57 ` [Qemu-devel] [RFC PATCH 1/5] allocate AIO on stack Frediano Ziglio
2011-07-20 7:57 ` [Qemu-devel] [RFC PATCH 2/5] use more stack Frediano Ziglio
2011-07-20 7:57 ` [Qemu-devel] [RFC PATCH 3/5] more stack work Frediano Ziglio
2011-07-20 7:57 ` [Qemu-devel] [RFC PATCH 4/5] avoid dandling pointers Frediano Ziglio
2011-07-20 7:57 ` [Qemu-devel] [RFC PATCH 5/5] qemu_aio_get used to clear all allocated buffer Frediano Ziglio
2011-07-20 13:05 ` Kevin Wolf
2011-07-20 13:45 ` Frediano Ziglio
2011-07-20 13:03 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E26D22B.1020606@redhat.com \
--to=kwolf@redhat.com \
--cc=freddy77@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).