From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:40891)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1QjWOP-00008o-Tu
	for qemu-devel@nongnu.org; Wed, 20 Jul 2011 09:00:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1QjWON-0003It-Ng
	for qemu-devel@nongnu.org; Wed, 20 Jul 2011 09:00:49 -0400
Received: from mx1.redhat.com ([209.132.183.28]:62348)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1QjWON-0003Ig-2a
	for qemu-devel@nongnu.org; Wed, 20 Jul 2011 09:00:47 -0400
Message-ID: <4E26D22B.1020606@redhat.com>
Date: Wed, 20 Jul 2011 15:03:39 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1311148624-5640-1-git-send-email-freddy77@gmail.com>
In-Reply-To: <1311148624-5640-1-git-send-email-freddy77@gmail.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH 0/5] Coroutines cleanup
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Frediano Ziglio <freddy77@gmail.com>
Cc: qemu-devel@nongnu.org

Am 20.07.2011 09:56, schrieb Frediano Ziglio:
> These patches mostly cleanup some AIO code using coroutines.
> These patches apply to Kevin's repository, branch coroutine-block.
> Mostly they use stack instead of allocated AIO structure.

I think your changes generally make sense as an example of how to
convert stuff to coroutines.

The thing that I'm not quite sure about is whether we should do it in
qcow1, which isn't frequently used and gets relatively little testing.
My main focus with qcow1 is keeping things working and maybe fixing
serious bugs. Code cleanups are always a (small, but not negligible)
risk of breaking things.

Anyway, I'm not totally opposed to merging this, but you really need to
improve the commit messages. First thing is that the subject should
start with the subsystem name ("qcow: Allocate AIOCB on stack"). I'm
also sure that you can be more precise than "more stack work". Please
use some more lines in the commit message to explain in more detail what
you're changing and ideally also why you're doing it.

Kevin