From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:36405) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjXpj-0007jD-VT for qemu-devel@nongnu.org; Wed, 20 Jul 2011 10:33:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QjXpd-0003UT-2O for qemu-devel@nongnu.org; Wed, 20 Jul 2011 10:33:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33403) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjXpc-0003Tl-EK for qemu-devel@nongnu.org; Wed, 20 Jul 2011 10:33:00 -0400 Message-ID: <4E26E716.2090109@redhat.com> Date: Wed, 20 Jul 2011 17:32:54 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1310901265-32051-1-git-send-email-avi@redhat.com> <20110719135601.GA7194@redhat.com> <4E25B85C.1030809@siemens.com> <4E25BB7A.7030105@redhat.com> <4E25BF26.6080900@siemens.com> <4E268E20.5050807@redhat.com> <4E26BF77.7070705@siemens.com> <4E26C290.8010604@redhat.com> <4E26DECC.9000700@siemens.com> In-Reply-To: <4E26DECC.9000700@siemens.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v4 00/58] Memory API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" , "Michael S. Tsirkin" On 07/20/2011 04:57 PM, Jan Kiszka wrote: > Something around dirty logging is still seriously borken: when I boot > with standard or cirrus vga, the screen is not properly updated in > logged modes. > I don't see this here, will retest. > I bet the reason is lacking semantics of > cpu_register_physical_memory_log(..., true), ie. the chance to register > a memory region with logging enabled. We need to explicitly enable it > now via memory_region_set_log, right? Is there any ordering issue to > expect, ie. when can I first call memory_region_set_log (as it issues > the start/stop client callbacks)? There should be no ordering issue at all. If you do a memory_region_set_log() immediately after memory_region_init_ram(), then as soon as the framebuffer is added to the memory hierarchy, it will have logging enabled (or any aliases of the framebuffer). -- error compiling committee.c: too many arguments to function