From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:36147) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qjacc-0008BY-Hm for qemu-devel@nongnu.org; Wed, 20 Jul 2011 13:31:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QjacY-0005Vz-Pe for qemu-devel@nongnu.org; Wed, 20 Jul 2011 13:31:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37900) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjacX-0005VF-Hu for qemu-devel@nongnu.org; Wed, 20 Jul 2011 13:31:41 -0400 Message-ID: <4E2710F6.6070909@redhat.com> Date: Wed, 20 Jul 2011 20:31:34 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1310901265-32051-1-git-send-email-avi@redhat.com> <1310901265-32051-12-git-send-email-avi@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v4 11/58] memory: add ioeventfd support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org On 07/20/2011 08:29 PM, Blue Swirl wrote: > > + > > +static bool memory_region_ioeventfd_before(MemoryRegionIoeventfd a, > > + MemoryRegionIoeventfd b) > > +{ > > + if (a.addr.start< b.addr.start) return true; > > + if (a.addr.start> b.addr.start) return false; > > + if (a.addr.size< b.addr.size) return true; > > + if (a.addr.size> b.addr.size) return false; > > + if (a.match_data< b.match_data) return true; > > + if (a.match_data> b.match_data) return false; > > + if (a.match_data) { > > + if (a.data< b.data) return true; > > + if (a.data> b.data) return false; > > + } > > + if (a.fd< b.fd) return true; > > + if (a.fd> b.fd) return false; > > NACK for CODING_STYLE. Just checking if you're awake. Will fix. -- error compiling committee.c: too many arguments to function