From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:57313) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QkC5x-00079Y-Gp for qemu-devel@nongnu.org; Fri, 22 Jul 2011 05:32:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QkC5v-0002Ug-Ob for qemu-devel@nongnu.org; Fri, 22 Jul 2011 05:32:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50354) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QkC5v-0002SW-FE for qemu-devel@nongnu.org; Fri, 22 Jul 2011 05:32:31 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6M9WU6v030078 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 22 Jul 2011 05:32:30 -0400 Message-ID: <4E2943AC.7010107@redhat.com> Date: Fri, 22 Jul 2011 11:32:28 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1311324757-4886-1-git-send-email-hdegoede@redhat.com> In-Reply-To: <1311324757-4886-1-git-send-email-hdegoede@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] spice-qemu-char: Generate chardev open/close events (v2) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hans de Goede Cc: qemu-devel@nongnu.org On 07/22/11 10:52, Hans de Goede wrote: > Define a state callback and make that generate chardev open/close events when > called by the spice-server. Note the code ignores these events for a spicevmc > with a subtypem of vdagent, this subtype specific knowledge is undesirable, > but unavoidable, see: > http://lists.freedesktop.org/archives/spice-devel/2011-July/004837.html > > Changes in v2: > -Only ignore the state callback for spicevmc chardevs with a subtype of > vdagent, instead of only allowing them for a subtype of usbredir What tree this is against? "git am" can't apply this cleanly to master. cheers, Gerd