From: Hans de Goede <hdegoede@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] spice-qemu-char: Generate chardev open/close events (v2)
Date: Fri, 22 Jul 2011 11:47:44 +0200 [thread overview]
Message-ID: <4E294740.5050809@redhat.com> (raw)
In-Reply-To: <4E2943AC.7010107@redhat.com>
Hi,
On 07/22/2011 11:32 AM, Gerd Hoffmann wrote:
> On 07/22/11 10:52, Hans de Goede wrote:
>> Define a state callback and make that generate chardev open/close events when
>> called by the spice-server. Note the code ignores these events for a spicevmc
>> with a subtypem of vdagent, this subtype specific knowledge is undesirable,
>> but unavoidable, see:
>> http://lists.freedesktop.org/archives/spice-devel/2011-July/004837.html
>>
>> Changes in v2:
>> -Only ignore the state callback for spicevmc chardevs with a subtype of
>> vdagent, instead of only allowing them for a subtype of usbredir
>
> What tree this is against? "git am" can't apply this cleanly to master.
>
Aginst my own tree, ubsredir branch, which includes Amit's chardev flow-control
patches + spicevmc flowcontrol patches:
http://cgit.freedesktop.org/~jwrdegoede/qemu/log/?h=usbredir
I thought all the changes where in bits untouched by this patch, but I guess I'm
wrong I'll do a new version against master. Also somehow I forgot to test compile
v2, shame on me... hence I just send v3, but you can ignore that as that still
won't apply to master.
Regards,
Hans
prev parent reply other threads:[~2011-07-22 9:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-22 8:52 [Qemu-devel] [PATCH] spice-qemu-char: Generate chardev open/close events (v2) Hans de Goede
2011-07-22 9:32 ` Gerd Hoffmann
2011-07-22 9:47 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E294740.5050809@redhat.com \
--to=hdegoede@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).