From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45283) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QkF1n-00018C-Ak for qemu-devel@nongnu.org; Fri, 22 Jul 2011 08:40:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QkF1m-00086g-Bn for qemu-devel@nongnu.org; Fri, 22 Jul 2011 08:40:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9095) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QkF1m-00086O-4T for qemu-devel@nongnu.org; Fri, 22 Jul 2011 08:40:26 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6MCePQs024704 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 22 Jul 2011 08:40:25 -0400 Message-ID: <4E296FAD.8070101@redhat.com> Date: Fri, 22 Jul 2011 14:40:13 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1311327655-5728-1-git-send-email-hdegoede@redhat.com> <20110722122519.GF2483@bow.tlv.redhat.com> In-Reply-To: <20110722122519.GF2483@bow.tlv.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] spice-qemu-char: Generate chardev open/close events (v3) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hans de Goede , qemu-devel@nongnu.org > ACK. > > Another option would be to not call the state callback for the vdagent > subtype from spice-server, because like you say it ignores the continued > communication between the agent and the server. Then you could remove > the subtype check. We can even #ifdef the check using SPICE_SERVER_VERSION once the spice-server change is committed, and in a year or so we can raise the minimum required spice-server version and remove some #ifdef clutter. cheers, Gerd