From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:44475)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1QkH2A-00063c-84
	for qemu-devel@nongnu.org; Fri, 22 Jul 2011 10:48:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1QkH29-0001hh-0y
	for qemu-devel@nongnu.org; Fri, 22 Jul 2011 10:48:58 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49564)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1QkH28-0001hN-LO
	for qemu-devel@nongnu.org; Fri, 22 Jul 2011 10:48:56 -0400
Message-ID: <4E298E82.4000802@redhat.com>
Date: Fri, 22 Jul 2011 16:51:46 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1311179069-27882-1-git-send-email-armbru@redhat.com>
	<1311179069-27882-10-git-send-email-armbru@redhat.com>
In-Reply-To: <1311179069-27882-10-git-send-email-armbru@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 09/55] block: Don't let locked flag prevent
	medium load
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: quintela@redhat.com, dbaryshkov@gmail.com, stefano.stabellini@eu.citrix.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, amit.shah@redhat.com

Am 20.07.2011 18:23, schrieb Markus Armbruster:
> Commit aea2a33c made bdrv_eject() obey the locked flag.  Correct for
> medium eject (eject_flag set), incorrect for medium load (eject_flag
> clear).  See MMC-5 Table 341 "Actions for Lock/Unlock/Eject".
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

SCSI doesn't really matter here, this is about host state. The comment
for bdrv_set_locked only talks about eject, so it's probably right anyway.

Kevin

> ---
>  block.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/block.c b/block.c
> index 594bcab..6727274 100644
> --- a/block.c
> +++ b/block.c
> @@ -2769,7 +2769,7 @@ int bdrv_eject(BlockDriverState *bs, int eject_flag)
>  {
>      BlockDriver *drv = bs->drv;
>  
> -    if (bs->locked) {
> +    if (eject_flag && bs->locked) {
>          return -EBUSY;
>      }
>